-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Forbid types with const generics on configurables #7494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #7494 will not alter performanceComparing Summary
|
tritao
approved these changes
Nov 20, 2025
PR SummaryForbids const-generic types in
Written by Cursor Bugbot for commit 62d6288. This will update automatically on new commits. Configure here. |
ironcev
approved these changes
Dec 10, 2025
xunilrj
added a commit
that referenced
this pull request
Dec 11, 2025
## Description Continuation of #7494. ## Checklist - [x] I have linked to any relevant issues. - [ ] I have commented my code, particularly in hard-to-understand areas. - [ ] I have updated the documentation where relevant (API docs, the reference, and the Sway book). - [ ] If my change requires substantial documentation changes, I have [requested support from the DevRel team](https://github.com/FuelLabs/devrel-requests/issues/new/choose) - [x] I have added tests that prove my fix is effective or that my feature works. - [ ] I have added (or requested a maintainer to add) the necessary `Breaking*` or `New Feature` labels where relevant. - [x] I have done my best to ensure that my PR adheres to [the Fuel Labs Code Review Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md). - [x] I have requested a review from the relevant team or maintainers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is continuation of #7483.
Checklist
Breaking*orNew Featurelabels where relevant.Note
Blocks types with const generics in configurables and ABI method args/returns via new
TypeId::has_const_generics, and adds tests to enforce errors.TypeId::has_const_generics(engines)to detect const generics in nested types (sway-core/src/type_system/id.rs).TyConfigurableDecl::forbid_const_generics()and invoke during type check (semantic_analysis/.../configurable.rs,.../declaration.rs).TypeId::has_const_genericsand remove ad-hoc checker (language/ty/declaration/abi.rs).should_fail/unsupported_const_genericsto cover configurables and ABI cases; update snapshot (test/.../stdout.snap).Written by Cursor Bugbot for commit eb61590. This will update automatically on new commits. Configure here.