fix: Avoid overflow in event check

[dkachuma]

This is a fix for the forecast set in EventBase. Depending on m_beginTime, time and if dt is too small, the value of (m_beginTime - time)/dt might be too large to be cast into an integer. On some systems this throws a floating point exception. This PR puts some checks so that we never overflow the integer.

[Copilot]

Pull request overview

This PR hardens EventBase::checkEvents against undefined behavior / SIGFPE when converting a potentially huge floating-point forecast value to an integer, by clamping the computed ratio to the representable range of integer before casting.

Changes:

• Compute the pre-start forecast as a floating-point ratio (m_beginTime - time) / dt.
• Clamp that ratio to [NumericLimits<integer>::min, NumericLimits<integer>::max] before casting to integer.
• Use the clamped forecast value when calling setForecast() to avoid overflow on conversion.

[rrsettgast]

@dkachuma Why is this an integer?

[dkachuma]

@dkachuma Why is this an integer?

I can't say I fully understand this. From the use it appears that we are 'forecasting' if the event will be active at the next step (forecast == 1). Otherwise the event is already active (forecast <= 0) or it's still idle (forecast > 1). So it's is the "expected number of code cycles before they are executed".

@cssherman Maybe you know better how this value is used.

[rrsettgast]

@dkachuma it sounds like it can be a floating point value.