Skip to content

fix: Avoid overflow in event check #4048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dkachuma wants to merge 2 commits into
base: develop
Choose a base branch
from
+9 −1
Open

fix: Avoid overflow in event check #4048

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
25e8709
Fix event check
dkachuma May 5, 2026
b3cff24
Merge branch 'develop' into dkachuma/fix-overflow-event-base
dkachuma May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/coreComponents/events/EventBase.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,15 @@ void EventBase::checkEvents( real64 const time,
}
else
{
this->setForecast( int( ( m_beginTime - time ) / dt ) );
real64 constexpr min_ratio = static_cast< real64 >(LvArray::NumericLimits< integer >::min);
real64 constexpr max_ratio = static_cast< real64 >(LvArray::NumericLimits< integer >::max);

real64 const ratio = ( m_beginTime - time ) / dt;

integer const forecast = ratio < min_ratio ? LvArray::NumericLimits< integer >::min :
(ratio > max_ratio ? LvArray::NumericLimits< integer >::max :
static_cast< integer >(ratio));
this->setForecast( forecast );
}
}
else if( time >= m_endTime )
Expand Down
Loading