Skip to content

Implement ECU Non-Critical Errors and Shutdown Logic#272

Draft
khoulihan27 wants to merge 22 commits intomainfrom
ECU-Shutdown/Error-Logic
Draft

Implement ECU Non-Critical Errors and Shutdown Logic#272
khoulihan27 wants to merge 22 commits intomainfrom
ECU-Shutdown/Error-Logic

Conversation

@khoulihan27
Copy link
Contributor

@khoulihan27 khoulihan27 commented Mar 2, 2026

Implement ECU Non-Critical Errors and Shutdown Logic

Problem and Scope

Implement non-critical errors as well as the shutdown logic for errors.
Implement error handling as a whole for ECU

Description

Gotchas and Limitations

Testing

  • HOOTL testing
  • HITL testing
  • Human tested

Testing Details

Larger Impact

Additional Context and Ticket

@dchansen06 dchansen06 force-pushed the ECU-Shutdown/Error-Logic branch from 5c4d6bd to bed7192 Compare March 3, 2026 06:59
@dchansen06 dchansen06 added Enhancement New feature or request 2 PRIORITY Important and a priority, but less than URGENT Big Fry Something that is complex and/or large Boards Related to or involving any physical boards labels Mar 5, 2026
@dchansen06 dchansen06 linked an issue Mar 5, 2026 that may be closed by this pull request
ECU Pathway For (Non)Critical Errors #129
Open
SlowThomas and others added 15 commits March 5, 2026 20:24
@SlowThomas
reduce some bloat in StateData
b39c345
@SlowThomas @khoulihan27
Reduce all timing-related states in StateData
ccdfc8b 
Co-authored-by: khoulihan27 <khoulihan27@users.noreply.github.com>
@kzwicker
reconcile state of charge with storage fmt
b850f64
@kzwicker
reconcile state of charge with storage fmt
48d5f12
@kzwicker
Merge branch 'ECU-Shutdown/Error-Logic' of https://github.com/Gaucho-…
e6af82b 
…Racing/Firmware into ECU-Shutdown/Error-Logic
@kzwicker
be so fr
25ab021
@github-actions
Automatic Clang-Format: Standardized formatting automatically
abbac89
@SlowThomas
Fix failling fdcan include for FDCAN_EXTENDED_ID
f6f84f8
@github-actions
Automatic Clang-Format: Standardized formatting automatically
5845e29
@SlowThomas @khoulihan27
Replace Comm Error checking with precharge timeout checking.
dd73c3b 
Co-authored-by: khoulihan27 <khoulihan@ucsb.edu>
@kzwicker
catch critical error in precharge engaged
2175d8b
@dchansen06
Merge branch 'main' into ECU-Shutdown/Error-Logic
1269c50
@SlowThomas
correct ts maximum permitted discharge time
93f53ab
@dchansen06
Merge branch 'main' into ECU-Shutdown/Error-Logic
2a3b814
@dchansen06
Merge branch 'main' into ECU-Shutdown/Error-Logic
ab58bf9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dchansen06 dchansen06 Awaiting requested review from dchansen06 dchansen06 will be requested when the pull request is marked ready for review dchansen06 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@SlowThomas SlowThomas

@kzwicker kzwicker

@khoulihan27 khoulihan27

Labels

2 PRIORITY Important and a priority, but less than URGENT Big Fry Something that is complex and/or large Boards Related to or involving any physical boards Enhancement New feature or request

Projects

None yet

Milestone

GR26 - Firmware Feature Freeze

Development

Successfully merging this pull request may close these issues.

ECU Pathway For (Non)Critical Errors

4 participants

@khoulihan27 @SlowThomas @dchansen06 @kzwicker