fix #151 (vendor): prevent writing "None" when agent_notes is None#252
Open
Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Open
fix #151 (vendor): prevent writing "None" when agent_notes is None#252Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Jean-Regis-M wants to merge 1 commit intoGenAI-Security-Project:mainfrom
Conversation
Refactor vendor notes update logic to handle None case. Signed-off-by: JEAN REGIS <240509606@firat.edu.tr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #151
update_vendor_agent_noteswriting the literal string"None"whenagent_notes=None(test case VND-NOTES-004).Problem
When called with
agent_notes=None, the function buildsnew_notes = f"{existing_notes}\n\n{agent_notes}".Python converts
Noneto"None", resulting in"\n\nNone"being appended to the vendor’s notes, corrupting the field.Root Cause
No guard against
Nonebefore the f‑string interpolation. The function assumesagent_notesis always a string, but the call site sometimes passesNone.Solution
Add an early return after the vendor is fetched and before any string manipulation: