Skip to content

fix #151 (vendor): prevent writing "None" when agent_notes is None #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Jean-Regis-M wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix #151 (vendor): prevent writing "None" when agent_notes is None #252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion finbot/tools/data/vendor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,11 +109,14 @@ async def update_vendor_agent_notes(
vendor_id,
agent_notes,
)
with db_session() as db:
with db_session() as db:
vendor_repo = VendorRepository(db, session_context)
vendor = vendor_repo.get_vendor(vendor_id)
if not vendor:
raise ValueError("Vendor not found")
# If agent_notes is None, no update is needed; return current data.
if agent_notes is None:
return vendor.to_dict()
existing_notes = vendor.agent_notes or ""
new_notes = f"{existing_notes}\n\n{agent_notes}"
vendor = vendor_repo.update_vendor(
Expand Down