Fixed SDgetcompinfo incorrect behavior#868
Draft
bmribler wants to merge 1 commit intoHDFGroup:hdf_4_3_1from
Draft
Fixed SDgetcompinfo incorrect behavior#868bmribler wants to merge 1 commit intoHDFGroup:hdf_4_3_1from
bmribler wants to merge 1 commit intoHDFGroup:hdf_4_3_1from
Conversation
When SZIP library is not available, SDgetcompinfo() fails even though it only needs to retrieve compression metadata, not actually compress/decompress data. The function should succeed in returning compression information regardless of whether the SZIP library is present. This PR removes check from HCIinit_coder() to allow metadata queries without the szip library. Known issue: Reading szip-compressed data from files opened with DFACC_RDWR when only decoder is available may fail. This is a pre-existing architectural issue where file open mode is conflated with operation type. This issue turned out to be too complicated to include in this PR, it will be addressed in a future fix.
bmribler
requested review from
brtnfld,
byrnHDF,
derobins,
fortnern,
glennsong09,
jhendersonHDF,
lrknox,
mattjala,
qkoziol,
schwehr and
vchoi-hdfgroup
as code owners
schwehr
reviewed
Mar 25, 2026
| Ref. = 6 | ||
| Compression method = SZIP | ||
| Compression information is unavailable (no SZIP library) | ||
| Option mask = H4_SZ_EC_OPTION_MASK|H4_SZ_RAW_OPTION_MASK (132) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When SZIP library is not available, SDgetcompinfo() fails even though it only needs to retrieve compression metadata, not actually compress/decompress data. The function should succeed in returning compression information regardless of whether the SZIP library is present.
This PR removes check from HCIinit_coder() to allow metadata queries without the szip library.
Fixes #867
Known issue: Reading szip-compressed data from files opened with DFACC_RDWR when only decoder is available may fail. This is a pre-existing architectural issue where file open mode is conflated with operation type. This issue turned out to be too complicated to include in this PR, it will be addressed in a future fix.