[BUGFIX] removing depreciated nodeModulesPath.#15
Open
webark wants to merge 2 commits intoHeroicEric:masterfrom
Open
[BUGFIX] removing depreciated nodeModulesPath.#15webark wants to merge 2 commits intoHeroicEric:masterfrom
webark wants to merge 2 commits intoHeroicEric:masterfrom
Conversation
based off of ember-cli/ember-cli#7401 `nodeModulesPath` has been depreciated, and `resolveSync` is a preferred alternative. `nodeModulesPath` has been removed in Ember Cli 3.x and it's use here breaks 3.x builds.
Author
|
@HeroicEric any word on you possibly getting this merged in? |
mmun
reviewed
Feb 16, 2018
| var normalizeTree = new Funnel(this.treeGenerator(normalizePath), { | ||
| srcDir: '/', | ||
| destDir: '/app/styles' | ||
| var normalizeModulePath = path.dirname(this.project.resolveSync('normalize.css')); |
There was a problem hiding this comment.
@webark resolveSync is a private method on project. require.resolve should work, no?
Author
There was a problem hiding this comment.
probably.. i just started doing an import statement and dropped this addon, which should be the preferred method going forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based off of ember-cli/ember-cli#7401
nodeModulesPathhas been depreciated, andresolveSyncis a preferred alternative.nodeModulesPathhas been removed in Ember Cli 3.x and it's use here breaks 3.x builds.