Skip to content

[BUGFIX] removing depreciated nodeModulesPath. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
webark wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[BUGFIX] removing depreciated nodeModulesPath. #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09c94d3
[BUGFIX] removing depreciated nodeModulesPath.
webark Jan 4, 2018
5d15d49
Using the funnel to bring in just the file.
webark Jan 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,10 @@ module.exports = {
name: 'ember-normalize',

treeForStyles: function() {
var normalizePath = path.join(this.project.nodeModulesPath, 'normalize.css');
var normalizeTree = new Funnel(this.treeGenerator(normalizePath), {
srcDir: '/',
destDir: '/app/styles'
var normalizeModulePath = path.dirname(this.project.resolveSync('normalize.css'));
Copy link
Copy Markdown

@mmun mmun Feb 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webark resolveSync is a private method on project. require.resolve should work, no?

Copy link
Copy Markdown
Author

@webark webark Feb 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably.. i just started doing an import statement and dropped this addon, which should be the preferred method going forward.

Copy link
Copy Markdown

@mmun mmun Feb 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@webark I just did the same :D

var normalizeTree = new Funnel(this.treeGenerator(normalizeModulePath), {
destDir: 'app/styles',
include: ['normalize.css']
});

return normalizeTree;
Expand Down