Skip to content

fix(CI): remove existing gh docker container#24

Merged
jjts merged 3 commits intoIObundle:mainfrom
P-Miranda:docker
Aug 7, 2025
Merged

fix(CI): remove existing gh docker container#24
jjts merged 3 commits intoIObundle:mainfrom
P-Miranda:docker

Conversation

@P-Miranda
Copy link
Contributor

  • start CI by trying to remove docker container and images if they still exist

arturum1 and others added 3 commits August 2, 2025 03:05
- start CI by trying to remove docker container and images if they still
  exist
@jjts jjts requested review from arturum1 and Copilot August 7, 2025 11:58
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes CI issues by ensuring clean Docker environment setup and includes some code formatting improvements. The main purpose is to prevent Docker container conflicts in CI by removing existing containers and images before building new ones.

  • Adds Docker cleanup step to remove existing containers and images before building
  • Updates macro name from _SWREG_ADDR_W to _CSRS_ADDR_W in generated header
  • Applies code formatting fixes (quote consistency and line wrapping)

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/ci.yml Adds Docker cleanup step to prevent container conflicts
scripts/drivers.py Updates macro name and applies formatting improvements

Comment on lines +71 to 72
fswhdr.write(f"#define {core_prefix}_CSRS_ADDR_W {mkregs_obj.core_addr_w}\n\n")

Copy link

Copilot AI Aug 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the macro name from _SWREG_ADDR_W to _CSRS_ADDR_W could be a breaking change for existing code that depends on this generated header. Ensure all references to the old macro name are updated accordingly.

Suggested change
fswhdr.write(f"#define {core_prefix}_CSRS_ADDR_W {mkregs_obj.core_addr_w}\n\n")
fswhdr.write(f"#define {core_prefix}_CSRS_ADDR_W {mkregs_obj.core_addr_w}\n")
fswhdr.write(f"#define {core_prefix}_SWREG_ADDR_W {mkregs_obj.core_addr_w} /* legacy name for compatibility */\n\n")

Copilot uses AI. Check for mistakes.
@jjts jjts merged commit 525d788 into IObundle:main Aug 7, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants