fix multithreading in jlfmt app#983
Open
digital-carver wants to merge 1 commit into
Open
Conversation
digital-carver
force-pushed
the
dcarv/appthreadsfix
branch
from
2eaffde to
b8b4c1f
Compare
Adds a minimal test against future regression in this too
digital-carver
force-pushed
the
dcarv/appthreadsfix
branch
from
b8b4c1f to
9efb204
Compare
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, running
jlfmtwith--threadsset to more than one thread leads to an error:This fixes it and makes
jlfmtcapable of using multithreading.A minimal test against future regression in this is added too.
(Resolves #953)