Open
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
==========================================
- Coverage 70.99% 70.20% -0.80%
==========================================
Files 5 6 +1
Lines 531 537 +6
==========================================
Hits 377 377
- Misses 154 160 +6 ☔ View full report in Codecov by Sentry. |
|
What's needed to get this running? |
Member
Author
|
We first need to merge the AbstractFFTs.jl extension. That was held up because there's no test plans for real transforms (like DCT). Also I got busy. I can probably complete this next month. |
vtjnash
pushed a commit
that referenced
this pull request
Aug 19, 2025
The motivation for this change is to allow adding extensions without adding unnecessary dependencies for users on pre-v1.10. In particular, this makes it easier to finish #311 and #318. See also JuliaMath/AbstractFFTs.jl#140 Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com> Co-authored-by: Steven G. Johnson <stevenj@mit.edu> Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves over code from FastTransformsForwardDiff.jl, and goes with JuliaMath/AbstractFFTs.jl#138