Set install directories depending on target type#374
Draft
matekelemen wants to merge 11 commits intomasterfrom
Draft
Set install directories depending on target type#374matekelemen wants to merge 11 commits intomasterfrom
matekelemen wants to merge 11 commits intomasterfrom
Conversation
Member
|
seems that this fails several CI configs |
Contributor
Author
|
Yep, I'm on it. I opened the PR to run the CI (should have done a draft). |
This reverts commit 4e452ba.
This was referenced Oct 29, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KratosMultiphysics/Kratos#13374 attempts to merge changes from #373, but it looks like I made a mistake at the install stage.
This PR sets the install directory depending on the target type, which is different on Linux and Windows.
Works with Kratos on my (Linux) system but the real question is Windows.