Default Spectrum-X settings from GPU platform - #155
Merged
Conversation
Derive the Spectrum-X mode and plane count from the documented GPU platform and east-west NIC combinations. Resolve --for preset hardware before profile defaults while keeping synthesized inventory transient. Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
Greptile SummaryThis PR derives Spectrum-X mode and plane-count defaults from GPU platform and east-west NIC inventory, while making preset hardware available before profile resolution without persisting synthetic inventory.
Confidence Score: 5/5The PR appears safe to merge; no concrete changed-code defect remains after reviewing the default-resolution, validation, preset, and persistence paths. The new platform mappings are covered for canonical discovery and preset identities, contradictory mode/plane pairs are rejected before rendering, and preset inventory drives resolution without being persisted over the source hardware configuration. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart LR
A[Load source configuration] --> B{--for preset?}
B -->|No| C[Use discovered clusterConfig]
B -->|Yes| D[Synthesize transient preset clusterConfig]
C --> E[Apply hardware defaults]
D --> E
E --> F[Apply explicit CLI overrides]
F --> G[Validate resolved profile]
G --> H[Render manifests]
G --> I[Write resolved profile back]
I --> J[Restore source clusterConfig for persistence]
Reviews (1): Last reviewed commit: "Default Spectrum-X settings from GPU pla..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multiplaneModeandnumberOfPlanesfrom GPU platform plus the east-west NIC inventorynone/1 and CX8 B300/GB300 to the conservative GAswplb/2 path--forpreset hardware before profile defaults without persisting synthetic preset inventoryPlatform decision
The current Network Operator documentation defines both SWPLB and HWPLB for B300 and GB300. Platform type therefore cannot identify which load-balancing mechanism is deployed. Launch Kit defaults the documented CX8 combinations to the GA SWPLB path; HWPLB remains an explicit site-topology choice. Quad-plane B300 also remains explicit because B300 supports both two and four planes.
Sources:
Validation
go test -race -count=1 ./...CGO_ENABLED=0 go build ./...CGO_ENABLED=0 go vet ./...golangci-lint v2.11 run ./...mkdocs build --strict