Moving example 11 to not use HOPP - #826
Draft
johnjasa wants to merge 3 commits into
Draft
Conversation
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace HOPP with native H2I models in example 11
This PR replaces HOPP with native H2I wind, solar, and battery models in example 11 (
examples/11_hybrid_energy_plant).The example now uses
PYSAMWindPlantPerformanceModel,PYSAMSolarPlantPerformanceModel, andPySAMBatteryPerformanceModeldirectly, connected through H2I's heuristic dispatch.Constraint metrics (load missed, curtailment) are now computed directly inside
DemandComponentBase.Changes summary:
percent_load_missedandcurtailment_percentoutputs toDemandComponentBaseso any demand component exposes these metrics.StoragePerformanceBase.setup()when max_charge_rate = 0.Section 1: Type of Contribution
Section 2: Draft PR Checklist
Section 3: General PR Checklist
Section 4: Related Issues
N/A
Section 5: Impacted Areas of the Software
Section 5.1: New Files
examples/11_hybrid_energy_plant/tech_inputs/desired_schedules/desired_schedule_hourly_kw.yamlSection 5.2: Modified Files
h2integrate/demand/demand_base.py: Addedpercent_load_missedandcurtailment_percentoutputs computed incalculate_outputs().h2integrate/converters/wind/wind_pysam.py: Changedturbine_rating_kwvalidator togte_zeroand added zero-capacity early return incompute().h2integrate/converters/solar/solar_pysam.py: Added zero-capacity early return andself.configalias for framework consistency.h2integrate/storage/battery/pysam_battery.py: Changed capacity validators togte_zeroand added zero-capacity early return.h2integrate/storage/storage_baseclass.py: Fixed division-by-zero whenmax_charge_rate = 0.examples/11_hybrid_energy_plant/tech_config.yaml: ReplacedHOPPComponentwith native wind, solar, combiner, battery, and demand technologies.examples/11_hybrid_energy_plant/plant_config.yaml: Added site resource config, interconnections, dispatch config, and finance subgroup.examples/11_hybrid_energy_plant/driver_config.yaml: Updated design variables and constraints to use native H2I outputs.examples/test/test_all_examples.py: Updated example 11 test for native H2I outputs.