nextcloud32: init at 32.0.0

[provokateurin]

Based on #446070 to avoid merge conflicts.

Things done

• Built on platform:
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• Tested, as applicable:
  • NixOS tests in nixos/tests.
  • Package tests at passthru.tests.
  • Tests in lib/tests or pkgs/test for functions and "core" functionality.
• Ran nixpkgs-review on this PR. See nixpkgs-review usage.
• Tested basic functionality of all binary files, usually in ./result/bin/.
• Nixpkgs Release Notes
  • Package update: when the change is major or breaking.
• NixOS Release Notes
  • Module addition: when adding a new NixOS module.
  • Module update: when the change is significant.
• Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

---

Add a 👍 reaction to pull requests you find important.

[provokateurin]

Would be cool if this can get reviewed and merged soon :)

[bachp]

Changes look OK to me. I didn't run any tests tough

[Ma27]

Will try to get to it tonight.

[SuperSandro2000]

I will shortly add a commit to fix memories and recognize for the new version.

error: memories currently does not support nextcloud version 32

[SuperSandro2000]

memories and recognize seem to work correctly afterwards

[Ma27]

LGTM, mostly. A few notes:

• we need release notes
• in nextcloud.md there's the latest version mentioned, this needs an update
• any opinions on what to do abotu this AppAPI deploy daemon thing? Personally, I'm not too interested in it given it's mostly for slop applications, but if there's a trivial knob to expose, we may wanna do it anyways.

Speaking of which...

It would be nice if we could somehow reduce the amount of changes needed to add/remove a major version, because I have to look at the git history every time to check what I need to do 😅

The version handling logic hasn't changed in 5 years notably, so I'm open to suggestions.
Personally, I don't have a really good idea given the information is so cluttered across multiple places (tests, module, docs) and there's no non-ad-hoc way to transfer informatnion between those, so I'm afraid I don't have a good answer.

[provokateurin]

any opinions on what to do abotu this AppAPI deploy daemon thing? Personally, I'm not too interested in it given it's mostly for slop applications, but if there's a trivial knob to expose, we may wanna do it anyways.

Same here, but is it specifically about this new major version? I don't really get what you are asking for.

[Ma27]

Same here, but is it specifically about this new major version? I don't really get what you are asking for.

I'm mostly asking because it was a red X in the setup check in the admin panel after deploying nc32.
And last time I kept something red in there it resulted in a bunch of support questions from people after that.

[provokateurin]

The only option is to disable the app, otherwise it will always trigger https://github.com/nextcloud/app_api/blob/main/lib/SetupChecks/DaemonCheck.php.
We could patch that (core/shipped.json) and not have the app enabled by default.

[Ma27]

Register occ app_api:daemon:register
Unregister occ app_api:daemon:unregister
List registered daemons occ app_api:daemon:list

yeah, I have even stronger reservations about this now.

I think it's OK, let's leave it at that.

[x10an14]

How come gpoddersync got lost in this PR?

❯ : git diff
diff --git a/nixos/nextcloud.nix b/nixos//nextcloud.nix
index 9d84e17..4cabda4 100644
--- a/nixos/nextcloud.nix
+++ b/nixos/nextcloud.nix
@@ -11,7 +11,7 @@
       {
         services.nextcloud = {
           enable = true;
-          package = pkgs.nextcloud31;
+          package = pkgs.nextcloud32;
           hostName = "nextcloud.${homelabFqdn}";
         };
       }

❯ : nom build .#nixosConfigurations.host.config.system.build.toplevel
warning: Git tree '/home/x10an14/Documents/nix-conf' is dirty
error:
       … while calling the 'head' builtin
         at /nix/store/nbbcr40rk108j1pckbn3g09php4j1r32-source/lib/attrsets.nix:1701:13:
         1700|           if length values == 1 || pred here (elemAt values 1) (head values) then
         1701|             head values
             |             ^
         1702|           else

       … while evaluating the attribute 'value'
         at /nix/store/nbbcr40rk108j1pckbn3g09php4j1r32-source/lib/modules.nix:1118:7:
         1117|     // {
         1118|       value = addErrorContext "while evaluating the option `${showOption loc}':" value;
             |       ^
         1119|       inherit (res.defsFinal') highestPrio;

       … while evaluating the option `system.build.toplevel':

       … while evaluating definitions from `/nix/store/nbbcr40rk108j1pckbn3g09php4j1r32-source/nixos/modules/system/activation/top-level.nix':

       … while evaluating the option `systemd.services.nginx.serviceConfig':

       … while evaluating definitions from `/nix/store/nbbcr40rk108j1pckbn3g09php4j1r32-source/nixos/modules/system/boot/systemd.nix':

       … while evaluating the option `systemd.services.nginx.preStart':

       … while evaluating definitions from `/nix/store/nbbcr40rk108j1pckbn3g09php4j1r32-source/nixos/modules/services/web-servers/nginx/default.nix':

       … while evaluating the option `services.nginx.virtualHosts."nextcloud.homelab.x10an14.xyz".root':

       … while evaluating the option `services.nextcloud.extraApps':

       … while evaluating definitions from `/nix/store/fcnbk6lvhzmvf8yfj27fnaqqfrl91isw-source/modules/nextcloud/config.nix, via option flake.modules.nixos.base':

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: attribute 'gpoddersync' missing
       at /nix/store/fcnbk6lvhzmvf8yfj27fnaqqfrl91isw-source/modules/nextcloud/config.nix:36:15:
           35|               files_automatedtagging # https://apps.nextcloud.com/apps/files_automatedtagging (automate tagging of files according to criteria)
           36|               gpoddersync # https://apps.nextcloud.com/apps/gpoddersync (sync antennapod)
             |               ^
           37|               integration_paperless # https://apps.nextcloud.com/apps/integration_paperless (upload files to paperless)
┏━ 1 Errors:
 ⋮
┃        error: attribute 'gpoddersync' missing
┃        at /nix/store/fcnbk6lvhzmvf8yfj27fnaqqfrl91isw-source/modules/nextcloud/config.nix:36:15:
┃            35|               files_automatedtagging # https://apps.nextcloud.com/apps/files_automatedtagging (automate tagging of files according to criteria)
┃            36|               gpoddersync # https://apps.nextcloud.com/apps/gpoddersync (sync antennapod)
┃              |               ^
┃            37|               integration_paperless # https://apps.nextcloud.com/apps/integration_paperless (upload files to paperless)
┣━━━
┗━ ∑ ⚠ Exited with 1 errors reported by nix at 23:03:48 after 3s

Ref

{ config, ... }: {
  # Nix installed apps
  services.nextcloud = {
    extraAppsEnable = true;
    extraApps = {
      # TODO: stalwart email
      inherit (config.services.nextcloud.package.packages.apps)
        calendar # https://apps.nextcloud.com/apps/calendar
        contacts # https://apps.nextcloud.com/apps/contacts
        dav_push # https://apps.nextcloud.com/apps/dav_push (calendar events pushing)
        files_automatedtagging # https://apps.nextcloud.com/apps/files_automatedtagging (automate tagging of files according to criteria)
        gpoddersync # https://apps.nextcloud.com/apps/gpoddersync (sync antennapod)
        integration_paperless # https://apps.nextcloud.com/apps/integration_paperless (upload files to paperless)
        news # https://apps.nextcloud.com/apps/news (rss feed(s) reader)
        notify_push # https://apps.nextcloud.com/apps/notify_push (push notifications w/default nextcloud files app)
        phonetrack # https://apps.nextcloud.com/apps/phonetrack (gps tracking & logging)
        richdocuments # https://apps.nextcloud.com/apps/richdocuments (google docs replacement)
        ;
    };
  };
}

[dotlambda]

@x10an14 thrillfall/nextcloud-gpodder#205

[x10an14]

@x10an14 thrillfall/nextcloud-gpodder#205

🙇 🤦 🙏