LLT-6859 configurable UAPI error handler #1618

LukasPukenis · 2025-12-05T11:46:47Z

Problem

Libtelio uses counter based mechanism when handling interface errors. The counter is used to ignore transient WireguardNT errors that happen around power-transitions and usually go away.

Current limitations:

Counter not reset after power-resume
Counter not aware of FeaturePolling::wireguard_polling_period_after_state_change
Hardcoded value of 10

These limitations allow libtelio to produce unnecessary critical failures that require libtelio restart.

Solution

Replace with configurable, time-based mechanism for critical errors handling instead.

☑️ Definition of Done checklist

Commit history is clean (requirements)
README.md is updated
Functionality is covered by unit or integration tests

mathiaspeters

+1

crates/telio-wg/src/wg.rs

stalowyjez

Looks rather ok, +1

crates/telio-model/src/features.rs

nat-lab/tests/test_events_link_state.py

crates/telio-wg/src/wg.rs

LukasPukenis · 2025-12-19T12:26:11Z

@stalowyjez I've addressed your comments

Replace the fixed count-based error handler with a duration-based mechanism which is configurable with FeatureInterfaceHealth. Signed-off-by: Lukas Pukenis <lukas.pukenis@nordsec.com>

Signed-off-by: Lukas Pukenis <lukas.pukenis@nordsec.com>

stalowyjez

lgtm, +1

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch 2 times, most recently from f9e65d3 to 4b9c0f6 Compare December 5, 2025 11:51

LukasPukenis changed the title ~~Llt 6859 configurable adapter gone error parameters~~ LLT-6859 configurable adapter-gone UAPI error parameters Dec 5, 2025

LukasPukenis temporarily deployed to Internal December 5, 2025 11:52 — with GitHub Actions Inactive

LukasPukenis changed the title ~~LLT-6859 configurable adapter-gone UAPI error parameters~~ LLT-6859 configurable adapter-gone error handler Dec 5, 2025

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from 4b9c0f6 to 1c17d77 Compare December 5, 2025 12:09

LukasPukenis temporarily deployed to Internal December 5, 2025 12:09 — with GitHub Actions Inactive

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from 1c17d77 to 2395810 Compare December 5, 2025 12:49

LukasPukenis temporarily deployed to Internal December 5, 2025 12:49 — with GitHub Actions Inactive

LukasPukenis mentioned this pull request Dec 5, 2025

Fix UAPI error tracker for backwards compatibility #1614

Closed

3 tasks

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from 2395810 to 8cbe327 Compare December 5, 2025 12:50

LukasPukenis temporarily deployed to Internal December 5, 2025 12:51 — with GitHub Actions Inactive

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from 8cbe327 to f581981 Compare December 5, 2025 14:51

LukasPukenis temporarily deployed to Internal December 5, 2025 14:51 — with GitHub Actions Inactive

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from f581981 to fa7b39c Compare December 5, 2025 14:54

LukasPukenis temporarily deployed to Internal December 5, 2025 14:55 — with GitHub Actions Inactive

LukasPukenis changed the title ~~LLT-6859 configurable adapter-gone error handler~~ LLT-6859 feature config for UAPI error handler Dec 5, 2025

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from fa7b39c to 5bc731b Compare December 9, 2025 14:20

LukasPukenis temporarily deployed to Internal December 9, 2025 14:21 — with GitHub Actions Inactive

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from 5bc731b to 825b681 Compare December 10, 2025 12:51

LukasPukenis temporarily deployed to Internal December 10, 2025 12:51 — with GitHub Actions Inactive

LukasPukenis changed the title ~~LLT-6859 feature config for UAPI error handler~~ LLT-6859 Dec 10, 2025

LukasPukenis changed the title ~~LLT-6859~~ LLT-6859 configurable UAPI error handler Dec 10, 2025

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from 825b681 to 1049dc7 Compare December 10, 2025 13:25

LukasPukenis temporarily deployed to Internal December 10, 2025 13:25 — with GitHub Actions Inactive

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from 1049dc7 to 5e76d91 Compare December 10, 2025 13:44

LukasPukenis temporarily deployed to Internal December 10, 2025 13:44 — with GitHub Actions Inactive

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from 5e76d91 to 6c9662a Compare December 10, 2025 13:56

LukasPukenis temporarily deployed to Internal December 10, 2025 13:56 — with GitHub Actions Inactive

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from 6c9662a to 45fe6a4 Compare December 10, 2025 13:58

LukasPukenis temporarily deployed to Internal December 10, 2025 13:58 — with GitHub Actions Inactive

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from 45fe6a4 to 068af66 Compare December 10, 2025 14:27

LukasPukenis temporarily deployed to Internal December 10, 2025 14:27 — with GitHub Actions Inactive

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from 068af66 to a778efd Compare December 10, 2025 14:35

LukasPukenis temporarily deployed to Internal December 10, 2025 14:35 — with GitHub Actions Inactive

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from a778efd to 3073f5e Compare December 10, 2025 14:44

LukasPukenis temporarily deployed to Internal December 10, 2025 14:44 — with GitHub Actions Inactive

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from 3073f5e to cde43e3 Compare December 11, 2025 14:45

LukasPukenis temporarily deployed to Internal December 11, 2025 14:45 — with GitHub Actions Inactive

LukasPukenis marked this pull request as ready for review December 12, 2025 07:18

LukasPukenis requested a review from a team as a code owner December 12, 2025 07:18

mathiaspeters reviewed Dec 12, 2025

View reviewed changes

crates/telio-wg/src/wg.rs Outdated Show resolved Hide resolved

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from cde43e3 to 853eb12 Compare December 12, 2025 12:40

LukasPukenis temporarily deployed to Internal December 12, 2025 12:40 — with GitHub Actions Inactive

stalowyjez reviewed Dec 18, 2025

View reviewed changes

LukasPukenis temporarily deployed to Internal December 19, 2025 11:06 — with GitHub Actions Inactive

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from 6906a0e to 9d4063f Compare December 19, 2025 12:15

LukasPukenis temporarily deployed to Internal December 19, 2025 12:15 — with GitHub Actions Inactive

LukasPukenis added 2 commits December 19, 2025 20:19

Improve UAPI error handler

47e6230

Replace the fixed count-based error handler with a duration-based mechanism which is configurable with FeatureInterfaceHealth. Signed-off-by: Lukas Pukenis <lukas.pukenis@nordsec.com>

Remove redundant code from test_events_link_state.py

3a76c6b

Signed-off-by: Lukas Pukenis <lukas.pukenis@nordsec.com>

LukasPukenis force-pushed the LLT-6859_configurable_adapter_gone_error_parameters branch from 9d4063f to 3a76c6b Compare December 19, 2025 18:21

LukasPukenis temporarily deployed to Internal December 19, 2025 18:21 — with GitHub Actions Inactive

stalowyjez approved these changes Dec 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

LLT-6859 configurable UAPI error handler #1618

LLT-6859 configurable UAPI error handler #1618

Uh oh!

LukasPukenis commented Dec 5, 2025 •

edited

Loading

Uh oh!

mathiaspeters left a comment

Uh oh!

Uh oh!

stalowyjez left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LukasPukenis commented Dec 19, 2025 •

edited

Loading

Uh oh!

stalowyjez left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LLT-6859 configurable UAPI error handler #1618

Are you sure you want to change the base?

LLT-6859 configurable UAPI error handler #1618

Uh oh!

Conversation

LukasPukenis commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

☑️ Definition of Done checklist

Uh oh!

mathiaspeters left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

stalowyjez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

LukasPukenis commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

stalowyjez left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LukasPukenis commented Dec 5, 2025 •

edited

Loading

LukasPukenis commented Dec 19, 2025 •

edited

Loading