[19.0][IMP] web_dark_mode: dark mode styles for responsive apps menu

[gerard-domatix]

When 'web_dark_mode' and 'web_responsive' are used together, the full-screen apps menu still uses light-theme colors: pale background, dark search text, and icons that don't match the dark UI.

This PR adds web_responsive as a dependency and includes dark styles for the apps menu so it stays consistent with the rest of the backend in dark mode.

Change is limited to __manifest__.py and a new apps_menu.dark.scss — no palette changes.

Screenshots

Same view in all cases: responsive apps menu open, dark mode enabled.

1. Before this PR

2. After this PR

3. After this PR (blue-dark palette preview, PR #3590)

• 1: web_dark_mode + web_responsive without these changes — apps menu stays on light colors in dark mode.
• 2: with this PR — apps menu matches the dark UI (current gray palette).
• 3: same fix with a blue-dark palette (PR [19.0][IMP] web_dark_mode: blue-dark color palette #3590) — illustrative preview only, not included here.

[pedrobaeza]

No need to manually change the version. In fact, this will conflict if we merge the other PR.

[gerard-domatix]

Done, thanks for the review!

[BhaveshHeliconia]

LGTM!

[ljmnoonan]

Thanks for the contribution! This has been a problem for a while now.

I like the style, however it should be in web_responsive, not web_dark_mode, and it should certainly not make web_dark_mode dependent on web_responsive

It is as simple as as putting this css file anywhere in web_responsive and adding it to web.assets_web_dark in the manifest.

I am also working on a solution for this as part of the project I started with #3387. It is a much bigger project though, and may wind up getting rejected due to its scope. You can see it here

In the meantime, this fixes the dark menu issue nicely.

[ljmnoonan]

This should be in web_responsive itself.

[ljmnoonan]

Even if you were to keep this in web_dark_mode you still would not need to have this dependency. You are not calling on any scss variables that are only defined in in web_responsive, so this css will just get loaded and do nothing

[len-foss]

The change is a welcome one :-)

It makes as much sense to put this here or to put it in web_responsive, doesn't it?
If it is preferred to to make a bridge module (which is totally understandable) it would indeed be important to not make one depend other the other (especially since there are bugs or unintended behaviours with web_responsive), so I think it would be enough to simply explain the situation in line comments/README.

[ljmnoonan]

@len-foss

It makes as much sense to put this here or to put it in web_responsive, doesn't it?

From a purely technical standpoint, yet, this is true. It will be added to the minimized css file either way.

However, from a code convention and organization point of view, every other module in odoo contains its own dark mode css assets suffixed with dark.scss so I don't see why this module should break this convention, especially considering how easy it is to avoid breaking convention

[len-foss]

However, from a code convention and organization point of view, every other module in odoo contains its own dark mode css assets suffixed with dark.scss so I don't see why this module should break this convention, especially considering how easy it is to avoid breaking convention

👍 makes total sense, thank you for the clarification.