-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[19.0][IMP] web_dark_mode: dark mode styles for responsive apps menu #3592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gerard-domatix
wants to merge
1
commit into
OCA:19.0
Choose a base branch
from
gerard-domatix:19.0-imp-web_dark_mode_apps_menu
base: 19.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+99
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
98 changes: 98 additions & 0 deletions
98
web_dark_mode/static/src/web_responsive/apps_menu.dark.scss
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should be in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| // Copyright 2026 Domatix | ||
| // License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
|
|
||
| // Dark overrides for the web_responsive apps menu. | ||
| // Use :root prefix to match web_responsive specificity and win by load order. | ||
|
|
||
| $app-menu-overlay: url("/web_responsive/static/src/img/home-menu-bg-overlay.svg"); | ||
|
|
||
| // Teal glow (#122e3a), radial focus from bottom-center | ||
| // to soften the transition with the navbar above. | ||
| $app-menu-glow: radial-gradient( | ||
| 120% 95% at 50% 108%, | ||
| rgba(28, 74, 95, 0.6), | ||
| rgba(28, 74, 95, 0) 64% | ||
| ); | ||
|
|
||
| :root .o_grid_apps_menu[data-theme="milk"] { | ||
| --app-menu-background: | ||
| #{$app-menu-glow}, #{$app-menu-overlay}, | ||
| linear-gradient(to bottom, #{$o-gray-200}, #{$o-gray-300}); | ||
| --app-menu-text-color: #{$o-gray-900}; | ||
| --app-menu-text-shadow: none; | ||
| --app-menu-hover-background: #{rgba($o-black, 0.08)}; | ||
| --apps-menu-scrollbar-background: #{$o-gray-500}; | ||
| --apps-menu-empty-search-color: #{$o-gray-900}; | ||
| } | ||
|
|
||
| :root .o_grid_apps_menu[data-theme="community"] { | ||
| --app-menu-background: | ||
| #{$app-menu-glow}, #{$app-menu-overlay}, | ||
| linear-gradient( | ||
| to bottom, | ||
| #{darken($o-brand-primary, 28%)}, | ||
| #{$o-brand-primary} | ||
| ); | ||
| --app-menu-text-color: #{$o-gray-900}; | ||
| --app-menu-text-shadow: none; | ||
| --app-menu-hover-background: #{rgba($o-black, 0.1)}; | ||
| --apps-menu-scrollbar-background: #{$o-gray-500}; | ||
| --apps-menu-empty-search-color: #{$o-gray-900}; | ||
| } | ||
|
|
||
| .o_grid_apps_menu { | ||
| .search-container { | ||
| .search-input { | ||
| background-color: $o-gray-300; | ||
|
|
||
| // web_responsive pins text to $app-menu-text-color (dark) without | ||
| // a dark-mode override. Force readable light text. | ||
| .form-control, | ||
| .search-icon { | ||
| color: $o-gray-900; | ||
| } | ||
|
|
||
| .form-control::placeholder { | ||
| color: $o-gray-900; | ||
| opacity: 0.5; | ||
| } | ||
| } | ||
|
|
||
| .search-item { | ||
| background-color: $o-gray-300; | ||
|
|
||
| &.highlight, | ||
| &:hover { | ||
| background-color: $o-gray-400; | ||
| } | ||
|
|
||
| // Result text lives in __name with its own dark color. | ||
| &__name { | ||
| color: $o-gray-900; | ||
| text-shadow: none; | ||
| } | ||
| } | ||
|
|
||
| .search-item-divider hr { | ||
| background-color: $o-gray-500; | ||
| } | ||
| } | ||
|
|
||
| .o-app-menu-item { | ||
| &__icon { | ||
| background-color: $o-gray-400 !important; | ||
| } | ||
|
|
||
| &__active { | ||
| color: $o-gray-900 !important; | ||
| text-shadow: 0 0 2px rgba($o-black, 0.4) !important; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| // When the apps menu opens over Discuss, the navbar keeps Discuss dark colors | ||
| // because Discuss stays mounted underneath. Force the standard navbar color | ||
| // only while the grid is open. | ||
| .o_apps_menu_opened .o_main_navbar.o_main_navbar { | ||
| background: $o-navbar-background !important; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if you were to keep this in
web_dark_modeyou still would not need to have this dependency. You are not calling on any scss variables that are only defined in inweb_responsive, so this css will just get loaded and do nothing