Skip to content

Sriamsh - Improve Daily Equipment Log User Experience#4701

Open
Sriamshreddy000 wants to merge 2 commits intodevelopmentfrom
sriamsh_improve_daily_equipment_log_ux
Open

Sriamsh - Improve Daily Equipment Log User Experience#4701
Sriamshreddy000 wants to merge 2 commits intodevelopmentfrom
sriamsh_improve_daily_equipment_log_ux

Conversation

@Sriamshreddy000
Copy link
Contributor

Description

Screenshot 2026-01-08 at 2 39 12 AM

Related PRS (if any):

This frontend PR is related to the backend development branch.

Main changes explained:

  • Improved the Daily Equipment Log user experience by adding a clear confirmation step before submitting equipment log updates to prevent accidental changes.
  • Added visible user feedback after a successful submission so users know when an entry has been recorded.
  • Refactored the submit flow to separate user intent (submit) from execution (confirm), improving clarity and maintainability.
  • Made minor UI adjustments to ensure the confirmation banner integrates cleanly with the existing layout across screen sizes.

How to test:

  1. check into current branch
  2. do npm install and npm start to run this PR locally
  3. Clear site data/cache
  4. log as admin user
  5. Navigate to Dashboard → Equipment → Daily Equipment Log
  6. Select a date and project, choose a log type (Check In or Check Out) then select one or more equipment items and click Submit, then verify the entry is submitted and also verify if a confirmation prompt appears.
  7. Click Cancel and confirm no update is made.
  8. Refresh the page and confirm data consistency.
  9. verify this new feature works in dark mode

Screenshots or videos of changes:

Submit button Submit toast message Mobile view

Note:

  • This PR focuses on UX improvements only and does not introduce backend or database changes.

@netlify
Copy link

netlify bot commented Jan 12, 2026

Deploy Preview for highestgoodnetwork-dev ready!

Name Link
🔨 Latest commit 2e0cb8e
🔍 Latest deploy log https://app.netlify.com/projects/highestgoodnetwork-dev/deploys/69a2a0c33288510008ae9ad7
😎 Deploy Preview https://deploy-preview-4701--highestgoodnetwork-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud
Copy link

@one-community one-community added the High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible label Feb 8, 2026
Copy link
Contributor

@sayali-2308 sayali-2308 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The core functionality works perfectly, but there's a CSS issue in dark mode that needs to be addressed before approval.

What Works Well:

  1. Confirmation Prompt: Yellow banner appears correctly with "Are you sure? This will update equipment availability." message and Cancel/Confirm buttons
  2. Success Notification: Green "Equipment logs updated successfully!" message displays after confirmation
  3. Cancel Functionality: Cancel button properly prevents updates
  4. Data Persistence: Data survives page refresh correctly
  5. UX Flow: Clear separation between user intent (submit) and execution (confirm)
  6. No Console Errors: Clean console in both light and dark modes
Image Image

Issues Found - Dark Mode:
Project Dropdown and Confirmation Prompt text CSS Issue:

  • The Project dropdown field appears with white/light background in dark mode
  • Makes the dropdown difficult to read and doesn't integrate cleanly with dark mode theme
  • This conflicts with the PR requirement: "Made minor UI adjustments to ensure the confirmation banner integrates cleanly with the existing layout"

Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sriamsh,

I have reviewed your PR locally and though the functionality works as per requirement on confirm and cancel as well as refresh. The only issue is the banner is not visible in clearly in dark mode.
Issue
Image
Image

Working functionality
Image
Image
Image
Image
Image

Copy link

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sriamsh,

Wel done with this implementation. Needs dark mode corrections.

Image Image

@Sriamshreddy000
Copy link
Contributor Author

Issues Found - Dark Mode: Project Dropdown and Confirmation Prompt text CSS Issue:

  • The Project dropdown field appears with white/light background in dark mode
  • Makes the dropdown difficult to read and doesn't integrate cleanly with dark mode theme
  • This conflicts with the PR requirement: "Made minor UI adjustments to ensure the confirmation banner integrates cleanly with the existing layout"

Hi Sriamsh,

I have reviewed your PR locally and though the functionality works as per requirement on confirm and cancel as well as refresh. The only issue is the banner is not visible in clearly in dark mode.

Hi Sriamsh,

Wel done with this implementation. Needs dark mode corrections.

Fixed the dark mode styling issue for the confirmation banner. It should now display correctly with proper contrast and visibility in dark mode.

Copy link

@rohanrastogi311 rohanrastogi311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sriamsh,

Thanks for working on this. The dark mode for the drop downs is still not implemented correctly.

Image

Copy link

@Anusha-Gali Anusha-Gali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Sriamsh,

I have reviewed your PR locally and thank you for fixing the banner. The dark mode issue mentioned by other reviewers does exist in your PR however the exact page is well adapted to dark mode in "Dev", so i suppose pulling the latest Dev and updating the local should help before merge.

Image Image

@Sriamshreddy000 Sriamshreddy000 force-pushed the sriamsh_improve_daily_equipment_log_ux branch from 063098b to 2e0cb8e Compare February 28, 2026 08:01
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

High Priority - Please Review First This is an important PR we'd like to get merged as soon as possible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants