Skip to content

Conversation

@ethanholz
Copy link
Collaborator

@ethanholz ethanholz commented Dec 19, 2025

Related to #1582.

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit by making a comment with pre-commit.ci autofix before requesting review.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@ethanholz ethanholz changed the title [WIP] Add support for result tokenizables to warehouse Add support for result tokenizables to warehouse Dec 19, 2025
@ethanholz ethanholz marked this pull request as ready for review December 19, 2025 22:06
@ethanholz ethanholz requested a review from atravitz December 19, 2025 22:06
@ethanholz
Copy link
Collaborator Author

One question I have on this before we review is whether we should be scoping tokenizables that each store can hold? My guess is yes, but I wasn't 100% sure. Either way, figured I would get this out so we can start the process here.

@ethanholz
Copy link
Collaborator Author

pre-commit.ci autofix

@ethanholz
Copy link
Collaborator Author

We may need to rebase the base branch so that tests can pass since they don't seem to be because of me.

@ethanholz
Copy link
Collaborator Author

In discussion with @atravitz we need to cherry-pick this into two PRs rather than keeping it monolithic.

@ethanholz
Copy link
Collaborator Author

@atravitz I removed the testing commit and this commit now blocks #1809 from merging, we are now ready for review.

@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat/warehouse@0e186a0). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/openfe/storage/warehouse.py 75.00% 3 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             feat/warehouse    #1763   +/-   ##
=================================================
  Coverage                  ?   92.19%           
=================================================
  Files                     ?      197           
  Lines                     ?    17179           
  Branches                  ?        0           
=================================================
  Hits                      ?    15838           
  Misses                    ?     1341           
  Partials                  ?        0           
Flag Coverage Δ
fast-tests 92.19% <75.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@atravitz atravitz merged commit efb3500 into OpenFreeEnergy:feat/warehouse Jan 23, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants