-
Notifications
You must be signed in to change notification settings - Fork 35
test: cleanup warehouse test to be more modular #1809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/warehouse
Are you sure you want to change the base?
test: cleanup warehouse test to be more modular #1809
Conversation
…o test/refactor-warehouse
…o test/refactor-warehouse
…o test/refactor-warehouse
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feat/warehouse #1809 +/- ##
=================================================
Coverage ? 92.20%
=================================================
Files ? 197
Lines ? 17194
Branches ? 0
=================================================
Hits ? 15854
Misses ? 1340
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
atravitz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, but I do expect we'll find some additional ways to stress-test this as we use it.
| ) | ||
|
|
||
| # | ||
| @pytest.mark.parametrize("fixture", ["benzene_variants_star_map"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing we're leaving this parameterize to make it easier to add more test cases?
This pull request refactors and expands the storage tests in
test_warehouse.pyto more comprehensively cover both thesetupandresultstores. The main improvements are the parameterization of tests to run against both store types, and the generalization of helper methods to support this. This increases test coverage and improves clarity.Test coverage and parameterization improvements:
"setup"and"result"stores, ensuring both are tested equally._test_store_load_same_processand_test_store_load_different_processare refactored to accept astore_nameparameter, allowing them to work with either store and improving code reuse.test_deletemethod is updated to use the new parameterization and helper method, ensuring deletion logic is tested for both stores.It is important to note that this PR will fail until #1763 is merged.
Checklist
newsentry, or the changes are not user-facing.pre-commit.ci autofix.Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).
Developers certificate of origin