Skip to content

Conversation

@ethanholz
Copy link
Collaborator

This pull request refactors and expands the storage tests in test_warehouse.py to more comprehensively cover both the setup and result stores. The main improvements are the parameterization of tests to run against both store types, and the generalization of helper methods to support this. This increases test coverage and improves clarity.

Test coverage and parameterization improvements:

  • All relevant test methods are now parameterized to run for both "setup" and "result" stores, ensuring both are tested equally.
  • Helper methods _test_store_load_same_process and _test_store_load_different_process are refactored to accept a store_name parameter, allowing them to work with either store and improving code reuse.
  • The test_delete method is updated to use the new parameterization and helper method, ensuring deletion logic is tested for both stores.

It is important to note that this PR will fail until #1763 is merged.

Checklist

  • All new code is appropriately documented (user-facing code must have complete docstrings).
  • Added a news entry, or the changes are not user-facing.
  • Ran pre-commit: you can run pre-commit locally or comment on this PR with pre-commit.ci autofix.

Manual Tests: these are slow so don't need to be run every commit, only before merging and when relevant changes are made (generally at reviewer-discretion).

Developers certificate of origin

@atravitz atravitz self-requested a review January 23, 2026 18:30
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (feat/warehouse@efb3500). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                @@
##             feat/warehouse    #1809   +/-   ##
=================================================
  Coverage                  ?   92.20%           
=================================================
  Files                     ?      197           
  Lines                     ?    17194           
  Branches                  ?        0           
=================================================
  Hits                      ?    15854           
  Misses                    ?     1340           
  Partials                  ?        0           
Flag Coverage Δ
fast-tests 92.20% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@atravitz atravitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but I do expect we'll find some additional ways to stress-test this as we use it.

)

#
@pytest.mark.parametrize("fixture", ["benzene_variants_star_map"])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing we're leaving this parameterize to make it easier to add more test cases?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants