Skip to content

[vote] Move user information from poll_ballot to separat collection#543

Merged
vkrasnovyd merged 23 commits into
OpenSlides:feature/votefrom
ostcar:split_poll_ballot
Jul 17, 2026
Merged

[vote] Move user information from poll_ballot to separat collection#543
vkrasnovyd merged 23 commits into
OpenSlides:feature/votefrom
ostcar:split_poll_ballot

Conversation

@ostcar

@ostcar ostcar commented Jul 3, 2026

Copy link
Copy Markdown
Member

@bastianjoel we (@rrenkert @MSoeb @bspekker ) talked, that it would be nice to save, which delegate send the vote.

We do this, but this information gets lost, when the poll gets anonymized. Currently, we only save the user ids in the field poll/voted_ids.

The Idea of this PR is, that we use different collections for the ballot and the user information. On non anonymed polls, its easy to connect them both with a relation.

On anonymized, the collection poll_ballot_user does not get deleted, but only the reference to poll_ballot.

On secret polls, I already delete all poll_ballot objects and recreate them. With this model-change, this has to be done, for any anonymize, so it is not possible to guess the relation between poll_ballot and poll_ballot_user with there incremented ids.

What do you think about this change? Its a bit late in the process. Would it still be possible for you do implement it in the client?

@bastianjoel

Copy link
Copy Markdown
Member

I don't see this getting used currently in the new vote implementation of the client. Therefore I guess its okay for me.

@bastianjoel

bastianjoel commented Jul 3, 2026

Copy link
Copy Markdown
Member

Nevermind - with the changes in poll_ballot this affects the current client implementation. IMHO the changes are okay, but when you have all necessary changes ready please wait with merging until I adjusted the client.
We are now at a point where I want to keep the feature branch functional at all times.

@ostcar

ostcar commented Jul 5, 2026

Copy link
Copy Markdown
Member Author

@vkrasnovyd

Copy link
Copy Markdown
Contributor

These changes also have to be implemented in the backend. I'll attach PR once it is ready.

Comment thread collections/poll_ballot_user.yml
@ostcar
ostcar requested a review from vkrasnovyd July 12, 2026 16:49
@ostcar

ostcar commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

@vkrasnovyd I am just curious: Is there a reason you removed the managed_by attribute? Was it only for meeting_delete?

@vkrasnovyd

Copy link
Copy Markdown
Contributor

@vkrasnovyd I am just curious: Is there a reason you removed the managed_by attribute? Was it only for meeting_delete?

Yes.

@vkrasnovyd
vkrasnovyd merged commit 6d54f65 into OpenSlides:feature/vote Jul 17, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants