You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We do this, but this information gets lost, when the poll gets anonymized. Currently, we only save the user ids in the field poll/voted_ids.
The Idea of this PR is, that we use different collections for the ballot and the user information. On non anonymed polls, its easy to connect them both with a relation.
On anonymized, the collection poll_ballot_user does not get deleted, but only the reference to poll_ballot.
On secret polls, I already delete all poll_ballot objects and recreate them. With this model-change, this has to be done, for any anonymize, so it is not possible to guess the relation between poll_ballot and poll_ballot_user with there incremented ids.
What do you think about this change? Its a bit late in the process. Would it still be possible for you do implement it in the client?
Nevermind - with the changes in poll_ballot this affects the current client implementation. IMHO the changes are okay, but when you have all necessary changes ready please wait with merging until I adjusted the client.
We are now at a point where I want to keep the feature branch functional at all times.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@bastianjoel we (@rrenkert @MSoeb @bspekker ) talked, that it would be nice to save, which delegate send the vote.
We do this, but this information gets lost, when the poll gets anonymized. Currently, we only save the user ids in the field
poll/voted_ids.The Idea of this PR is, that we use different collections for the ballot and the user information. On non anonymed polls, its easy to connect them both with a relation.
On anonymized, the collection
poll_ballot_userdoes not get deleted, but only the reference topoll_ballot.On secret polls, I already delete all
poll_ballotobjects and recreate them. With this model-change, this has to be done, for any anonymize, so it is not possible to guess the relation betweenpoll_ballotandpoll_ballot_userwith there incremented ids.What do you think about this change? Its a bit late in the process. Would it still be possible for you do implement it in the client?