Skip to content

Add publishing integrity check after releasing - #4045

Merged
frangio merged 25 commits into
OpenZeppelin:masterfrom
ernestognw:lib-696-implement-integrity-check-in-releaseyaml
Feb 15, 2023
Merged

Add publishing integrity check after releasing#4045
frangio merged 25 commits into
OpenZeppelin:masterfrom
ernestognw:lib-696-implement-integrity-check-in-releaseyaml

Conversation

@ernestognw

@ernestognw ernestognw commented Feb 14, 2023

Copy link
Copy Markdown
Member

Description

Add an integrity check to ensure contracts were packed exactly as they're in the repository.

Checklist

  • Test release on a dummy package

@ernestognw
ernestognw requested a review from frangio February 14, 2023 20:27
@changeset-bot

changeset-bot Bot commented Feb 14, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0583798

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@frangio frangio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor style comments:

Comment thread .github/workflows/release-cycle.yml Outdated
Comment thread .github/workflows/release-cycle.yml Outdated
Comment thread .github/workflows/release-cycle.yml Outdated
@ernestognw

Copy link
Copy Markdown
Member Author

Action lint is failing because the download-path is not declared in the artifact/download action .yaml.
The fix is already merged but we might want to wait until it's released. Another option is to ignore the error somehow but I don't like the idea.

What do you think? @frangio

@ernestognw
ernestognw requested a review from frangio February 15, 2023 03:11
@frangio

frangio commented Feb 15, 2023

Copy link
Copy Markdown
Contributor

We can use the latest commit even if it's not tagged yet: actions/download-artifact@e9ef242655d12993efdcda9058dee2db83a2cb9b.

Comment thread .github/workflows/release-cycle.yml
@ernestognw
ernestognw requested a review from frangio February 15, 2023 19:39
@frangio
frangio merged commit 4e8aa43 into OpenZeppelin:master Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants