Fix flaky timestamp tests - #4046
Conversation
|
|
The test suite is going a lot slower than before. Is it due to this PR? |
|
Test suite took twice the time it usually takes. I'm disabling gas reporting to see if it helps. |
gas report definitelly making all tests WAY slower |
9283c05 to
49ccb68
Compare
|
|
It made sens that d79c2ec would fix the issue of flaky timestamps, but I'm not sure how we expect the current version of the PR to do anything since the behavior for timestamps in |
|
@Amxx I'm just trying things out to debug the test time degradation. |
They are due to an how OpenZeppelin Test Helpers implements
time.increaseTo. We should prefer Hardhat's own network helpers (eventually we should migrate the rest of the test suite).I also included a small refactor of
.thenin the Governor helper.Fixes #4049