rename transform with output in existing output error message#356
Merged
mathieudpnt merged 1 commit intoProject-OSmOSE:mainfrom Mar 26, 2026
Merged
rename transform with output in existing output error message#356mathieudpnt merged 1 commit intoProject-OSmOSE:mainfrom
mathieudpnt merged 1 commit intoProject-OSmOSE:mainfrom
Conversation
Collaborator
mathieudpnt
approved these changes
Mar 26, 2026
Merged
mathieudpnt
pushed a commit
that referenced
this pull request
Mar 26, 2026
* Revert "rename transform with output in existing output error message (#356)" This reverts commit 452b23c. * replace Project.rename_output() with Project.rename_transform_with_outputs(Ã) * adapt Project.run() error msg for duplicate transform names * replace delete_output() with delete_transform_with_outputs() * fix error message expectation in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running a transform while a transform with the same name had already be run (meaning there already was an output with the same name), the error message was:
"Transform {transform.name} already exists. Please choose a different name, or delete it with the Project.delete_output() method."Transformhere was a bit misleading, as the problem is that aTransformwith the same name had already be run: the issue really is that an output already has the nametransform.name.I changed the error message to this: