fix: Generate Plan factory with correct variant class names#779
Merged
Conversation
🦋 Changeset detectedLatest commit: f735245 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🔍 PHP SDK Changes PreviewDiff is too large to display inline 📦 Download the rebilly-sdk-diff artifact from the workflow run for a formatted HTML diff. Updated: 2026-06-05 15:51:40 UTC |
elgouttefangeas
previously approved these changes
Jun 5, 2026
colinbird
approved these changes
Jun 5, 2026
elgouttefangeas
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
model-factory-Plan.php.handlebarstemplate hardcoded references toTrialOnlyPlan,SubscriptionPlan, andOneTimeSalePlan, but the bare-named classes no longer exist in the generated SDK, so the factory files fail Psalm withUndefinedClasserrors.This PR interpolates
{{model.className}}into each variant reference so the template emits the correct class names for bothPlanand FlexiblePlan. After merging this, the next workflow run will regeneratesrc/Model/PlanFactory.phpandsrc/Model/FlexiblePlanFactory.phpto point at classes that actually exist.