Skip to content

fix: Generate Plan factory with correct variant class names #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ninjasimon merged 2 commits into from
Jun 5, 2026
Merged

fix: Generate Plan factory with correct variant class names #779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19919b1
fix: Generate Plan factory with correct variant class names
ninjasimon Jun 5, 2026
f735245
Add changeset
ninjasimon Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changeset/fair-dodos-see.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
---
6 changes: 3 additions & 3 deletions sdk-generator/templates/model-factory-Plan.php.handlebars
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,12 @@ class {{model.className}}Factory
public static function from(array $data = [], array $metadata = []): {{model.className}}
{
if ($data['isTrialOnly'] ?? false) {
return TrialOnlyPlan::from($data, $metadata);
return {{model.className}}TrialOnlyPlan::from($data, $metadata);
}
if (isset($data['recurringInterval'])) {
return SubscriptionPlan::from($data, $metadata);
return {{model.className}}SubscriptionPlan::from($data, $metadata);
}

return OneTimeSalePlan::from($data, $metadata);
return {{model.className}}OneTimeSalePlan::from($data, $metadata);
}
}
Loading