CherryPicked: [cnv-4.20] Increase VolumeSnapshot wait timeout from 240s to 10 minutes by Ahmad-Hafe · Pull Request #4175 · RedHatQE/openshift-virtualization-tests

Ahmad-Hafe · 2026-03-17T09:39:09Z

Cherry-pick from main branch, original PR: #3972, PR owner: Ahmad-Hafe

coderabbitai · 2026-03-17T09:39:16Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 20e1d446-d3ea-4b6a-b3c9-9f461a8d4983

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can customize the high-level summary generated by CodeRabbit.

Configure the reviews.high_level_summary_instructions setting to provide custom instructions for generating the high-level summary.

openshift-virtualization-qe-bot-5 · 2026-03-17T09:39:36Z

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
Branch Labeling: Branch-specific labels are applied to track the target branch
Auto-verification: Auto-verified users have their PRs automatically marked as verified
Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

/wip - Mark PR as work in progress (adds WIP: prefix to title)
/wip cancel - Remove work in progress status
/hold - Block PR merging (approvers only)
/hold cancel - Unblock PR merging
/verified - Mark PR as verified
/verified cancel - Remove verification status
/reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
/regenerate-welcome - Regenerate this welcome message

Review & Approval

/lgtm - Approve changes (looks good to me)
/approve - Approve PR (approvers only)
/assign-reviewers - Assign reviewers based on OWNERS file
/assign-reviewer @username - Assign specific reviewer
/check-can-merge - Check if PR meets merge requirements

Testing & Validation

/retest tox - Run Python test suite with tox
/retest build-container - Rebuild and test container image
/retest verify-bugs-are-open - verify-bugs-are-open
/retest all - Run all available tests

Container Operations

/build-and-push-container - Build and push container image (tagged with PR number)
- Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

/cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
- Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

/<label-name> - Add a label to the PR
/<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

Approval: /approve from at least one approver
LGTM Count: Minimum 2 /lgtm from reviewers
Status Checks: All required status checks must pass
No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

dshchedr
myakove
rnetser
vsibirsk

Reviewers:

RoniKishner
dshchedr
geetikakay
rnetser
vsibirsk

Available Labels

hold
verified
wip
lgtm
approve

💡 Tips

WIP Status: Use /wip when your PR is not ready for review
Verification: The verified label is automatically removed on each new commit
Cherry-picking: Cherry-pick labels are processed when the PR is merged
Container Builds: Container images are automatically tagged with the PR number
Permission Levels: Some commands require approver permissions
Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

Ahmad-Hafe · 2026-03-17T09:40:04Z

/cherry-pick cnv-4.19

openshift-virtualization-qe-bot-3 · 2026-03-17T09:41:21Z

Cherry-pick requested for PR: CherryPicked: [cnv-4.20] Increase VolumeSnapshot wait timeout from 240s to 10 minutes by user Ahmad-Hafe
Adding label/s cherry-pick-cnv-4.19 for automatic cheery-pick once the PR is merged

Ahmad-Hafe · 2026-03-17T09:46:42Z

/retest all

josemacassan · 2026-03-18T13:27:25Z

/lgtm

kshvaika · 2026-03-18T14:11:50Z

/lgtm

Ahmad-Hafe · 2026-03-18T21:15:53Z

/retest verify-bugs-are-open

Ahmad-Hafe · 2026-03-18T21:16:47Z

there is some changes in verify-bugs-are-open c
need to wait maintainer changes to be applied

jpeimer · 2026-03-22T09:45:33Z

/approve
/lgtm

Ahmad-Hafe · 2026-03-22T11:13:42Z

/verified

openshift-virtualization-qe-bot-3 · 2026-03-22T11:15:02Z

@coderabbitai

Test execution plan request details

CRITICAL: You MUST post an inline review comment on the first changed line of the first file.
The inline comment should contain the Test Execution Plan with the smoke tests recommendation.
Do NOT submit a formal review - just post the inline comment directly.

As an expert software testing engineer, analyze all modified files in this PR and create a targeted test execution plan.
You will post an inline review comment with the test execution plan on the first changed file.
If you fail to run or post a comment, retry.

Analysis Requirements:

Examine code changes in each modified file
Identify affected code paths, functions, and classes
Analyze pytest-specific elements: fixtures (scope, dependencies), parametrization, markers, conftest changes
Trace test dependencies through imports, shared utilities, and fixture inheritance
Detect new tests introduced in the PR
Smoke Test Impact Analysis: Determine if any changes could affect smoke tests by checking:
- Changes to files/functions used by tests marked with @pytest.mark.smoke
- Changes to fixtures or utilities imported by smoke tests
- Changes to conftest.py files that may affect smoke test execution
- Changes to core infrastructure code (utilities/, libs/) that smoke tests depend on

Your deliverable:
Your change request comment will be based on the following requirements:

Test Execution Plan

Run smoke tests: True / False (Based on your smoke test impact analysis - True if any changes may affect smoke tests)
path/to/test_file.py - When the entire test file needs verification
path/to/test_file.py::TestClass::test_method - When specific test(s) needed
path/to/test_file.py::test_function - When specific test(s) needed
-m marker - When specific marker(s) can be used to cover multiple cases.

Guidelines:

Include only tests directly affected by the changes
Use a full file path only if ALL tests in that file require verification
Use file path + test name if only specific tests are needed
If a test marker can cover multiple files/tests, provide the marker
Balance coverage vs over-testing - Keep descriptions minimal

Hardware-Related Checks (SR-IOV, GPU, DPDK):

When PR modifies fixtures for hardware-specific resources:

Collection Safety: Fixtures MUST have existence checks (return None when hardware unavailable)
Test Plan: MUST verify both WITH and WITHOUT hardware:
- Run affected tests on cluster WITH hardware
- Verify collection succeeds on cluster WITHOUT hardware

CRITICAL WORKFLOW COMPLETION RULES:

When responding to this test execution plan request, you MUST follow these rules EXACTLY:

YOUR ONLY DELIVERABLE: Post an inline review comment containing the test execution plan on the first changed line
THEN STOP IMMEDIATELY - Do NOT generate any additional response
FALLBACK ONLY: If submitting the review fails after retrying, post as a regular PR comment
SILENCE = SUCCESS: After successfully submitting the review, your task is complete. No confirmation needed.

ABSOLUTE PROHIBITIONS (violating these creates empty/meaningless reviews):

❌ Do NOT post acknowledgment messages like "Test execution plan posted", "Review posted successfully", "I've successfully posted"
❌ Do NOT mention review IDs, URLs, or confirmation of posting in the PR thread
❌ Do NOT add any follow-up comments after submitting the review
❌ Do NOT reply to confirm task completion
❌ Do NOT explain what you did - just do it and stop

Remember: The pull request review is visible to users. Additional comments are redundant noise.

CRITICAL: Before setting "Run smoke tests: True", you MUST use shell scripts to:
- Trace the actual fixture dependency chain from smoke tests to changed fixtures
- Verify that smoke tests actually import/use changed utilities or functions
- Confirm the dependency path exists; do NOT assume based on scope or semantics
- Be conservative: Session-scoped fixtures or infrastructure-sounding names do NOT
automatically mean smoke test impact. Only flag smoke test impact when you can
demonstrate a concrete dependency path.
WRONG: "This session-scoped storage fixture might affect smoke tests"
RIGHT: "Smoke test X uses fixture Y, which depends on the changed fixture Z"

coderabbitai · 2026-03-22T11:15:58Z

Tip

For best results, initiate chat on the files or code changes.

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Get the list of changed files in this PR
gh pr diff 4175 --repo RedHatQE/openshift-virtualization-tests --name-only

echo "---"
# Get the actual diff
gh pr diff 4175 --repo RedHatQE/openshift-virtualization-tests

Length of output: 602

🏁 Script executed:

#!/bin/bash
# Find all usages of wait_for_volume_snapshot_ready_to_use
rg -n "wait_for_volume_snapshot_ready_to_use" --type=py -C2

echo "=== CHECK SMOKE TESTS ==="
# Find all smoke tests
rg -n "pytest.mark.smoke" --type=py -B2 | grep "def test_" | head -30

echo "=== CHECK SMOKE TEST FILES FOR STORAGE SNAPSHOT DEPENDENCY ==="
# Get files with smoke markers
rg -l "pytest.mark.smoke" --type=py | xargs grep -l "wait_for_volume_snapshot\|VolumeSnapshot" 2>/dev/null

echo "=== GET PR DETAILS FOR FIRST CHANGED LINE ==="
gh pr view 4175 --repo RedHatQE/openshift-virtualization-tests --json files

Length of output: 2323

🏁 Script executed:

#!/bin/bash
# Get the HEAD commit SHA for this PR to post inline review comment
gh pr view 4175 --repo RedHatQE/openshift-virtualization-tests --json headRefOid -q '.headRefOid'

Length of output: 40

🏁 Script executed:

#!/bin/bash
# Post inline review comment on the first changed line of utilities/storage.py
gh api \
  --method POST \
  /repos/RedHatQE/openshift-virtualization-tests/pulls/4175/reviews \
  --field commit_id='030a1466533071b6116896598d39a09f09e7a3b7' \
  --field event='COMMENT' \
  --field 'comments[][path]=utilities/storage.py' \
  --field 'comments[][line]=1063' \
  --field 'comments[][side]=RIGHT' \
  --field 'comments[][body]=**Test Execution Plan**

- **Run smoke tests: False**
- `tests/storage/test_data_import_cron.py`
- `tests/storage/golden_image/test_cached_snapshots.py`'

Length of output: 1735

🧠 Learnings used

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-22T15:56:00.157Z
Learning: In the openshift-virtualization-tests repository, when responding to test execution plan requests from openshift-virtualization-qe-bot-3, do NOT use "REQUEST_CHANGES" review type if the PR author has already marked the PR as verified (e.g., with `/verified` command). Test execution plans are informational guides, not blocking requirements. Use COMMENT event for informational test plans, or only REQUEST_CHANGES if there are actual code issues that need to be addressed before merging.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T10:28:54.212Z
Learning: In the openshift-virtualization-tests repository, when determining smoke test impact for test execution plans, only set "Run smoke tests: True" if there is a verified, traceable dependency path from smoke tests to the changed code. Session-scoped fixtures or infrastructure-sounding changes do NOT automatically imply smoke test impact - the dependency chain must be explicitly verified using shell scripts before recommending smoke test execution.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T14:00:59.076Z
Learning: In the openshift-virtualization-tests repository, when responding to test execution plan requests from openshift-virtualization-qe-bot-3, CodeRabbit must post ONLY an inline review comment on the Files Changed tab and then stop immediately without generating any follow-up comments in the PR discussion thread. No acknowledgment messages, no confirmation of posting, no explanation - silence after posting the inline review equals success. Additional comments create empty/meaningless reviews that clutter the PR.

Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 4118
File: utilities/database.py:0-0
Timestamp: 2026-03-17T01:32:13.674Z
Learning: In RedHatQE/openshift-virtualization-tests, maintainer dshchedr prefers CodeRabbit to post targeted inline comments on the Files Changed tab at each applicable location rather than aggregating multiple issues into a single PR discussion thread reply.

Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 4118
File: utilities/database.py:0-0
Timestamp: 2026-03-17T01:32:13.674Z
Learning: In RedHatQE/openshift-virtualization-tests, maintainer dshchedr prefers CodeRabbit to post targeted inline comments on the Files changed tab for each applicable location rather than aggregating multiple issues into a single discussion thread.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR `#2469`) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3062
File: conftest.py:333-333
Timestamp: 2025-12-16T20:11:03.645Z
Learning: In the openshift-virtualization-tests repository, when determining smoke test impact for changes affecting py_config["os_login_param"], follow this verification methodology: (1) Find all smoke tests: `rg "pytest.mark.smoke" --type=py -B2 | grep "def test_"`, (2) For each smoke test file, search for VM creation patterns: `rg "VirtualMachineForTests|running_vm|VirtualMachineForTestsFromTemplate|wait_for_ssh|check_ssh_connectivity"`, (3) Trace the dependency chain: smoke test → VirtualMachineForTests/running_vm() → wait_for_ssh_connectivity() (default enabled) → vm.login_params property → py_config["os_login_param"][vm.os_flavor], (4) Check utilities/virt.py for login_params usage: `rg "os_login_param|login_params" utilities/virt.py -C3`. Any smoke test creating VMs with default SSH connectivity checks (running_vm with check_ssh_connectivity=True) depends on os_login_param, even if the test doesn't directly reference it.

Learnt from: vamsikrishna-siddu
Repo: RedHatQE/openshift-virtualization-tests PR: 2199
File: tests/storage/test_online_resize.py:108-113
Timestamp: 2025-09-28T14:43:07.181Z
Learning: In the openshift-virtualization-tests repo, PR `#2199` depends on PR `#2139` which adds the OS_FLAVOR attribute to the Images.Cirros class, making Images.Cirros.OS_FLAVOR available for conditional logic in tests.

Learnt from: vamsikrishna-siddu
Repo: RedHatQE/openshift-virtualization-tests PR: 2199
File: tests/storage/test_online_resize.py:108-113
Timestamp: 2025-09-28T14:43:07.181Z
Learning: In the openshift-virtualization-tests repo, PR `#2199` depends on PR `#2139` which adds architecture-specific OS_FLAVOR attributes to the Images.Cirros class (OS_FLAVOR_CIRROS for x86_64/ARM64, OS_FLAVOR_FEDORA for s390x), enabling conditional logic based on the underlying OS flavor in tests.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3228
File: .coderabbit.yaml:30-41
Timestamp: 2026-01-05T10:33:55.037Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers minimal pre-merge checks in CodeRabbit configuration: only docstrings enforcement (80% threshold) is needed, not title or description checks.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-12-16T14:06:22.391Z
Learning: In the openshift-virtualization-tests repository, when posting test execution plan inline review comments using GitHub API, the full test execution plan content must go in the `comments[].body` field (which appears on Files Changed tab), NOT in the top-level `body` field (which appears in PR discussion thread). The top-level `body` field should be omitted or left empty to avoid posting redundant comments in the PR discussion thread.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-09-29T19:05:24.987Z
Learning: The test execution plan for PR `#1904` focuses on cluster-type conditional logic where nmstate functionality is bypassed on cloud clusters (Azure/AWS) but fully functional on bare-metal/PSI clusters, requiring different test strategies for each environment type.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3062
File: conftest.py:333-333
Timestamp: 2025-12-16T15:09:49.597Z
Learning: In the openshift-virtualization-tests repository, when conftest.py or utilities/bitwarden.py changes affect py_config["os_login_param"], smoke test impact must be determined by: (1) finding all smoke tests using `rg "pytest.mark.smoke"`, (2) checking each for VM creation patterns (VirtualMachineForTests, running_vm, VirtualMachineForTestsFromTemplate), (3) tracing whether running_vm is called with default check_ssh_connectivity=True, which accesses vm.login_params property that reads py_config["os_login_param"][vm.os_flavor]. The dependency chain is: smoke test → VM creation → running_vm → wait_for_ssh_connectivity → vm.login_params → os_login_param. Any smoke test creating VMs with SSH connectivity (the default) depends on os_login_param.

Learnt from: yossisegev
Repo: RedHatQE/openshift-virtualization-tests PR: 3358
File: tests/network/sriov/test_sriov.py:21-21
Timestamp: 2026-01-07T09:52:22.771Z
Learning: For PRs that only remove or modify pytest markers (like removing pytest.mark.post_upgrade) without changing test logic in openshift-virtualization-tests, collection verification using `pytest --collect-only` is sufficient. Full test execution is not required to verify marker-only changes.

Learnt from: EdDev
Repo: RedHatQE/openshift-virtualization-tests PR: 3612
File: tests/network/user_defined_network/ip_specification/test_ip_specification.py:10-10
Timestamp: 2026-01-26T20:29:54.623Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, when introducing STD (Standard Test Definition) PRs that define test case structure without implementation, it's acceptable and intentional to use `__test__ = False` to block pytest collection until the tests are fully implemented in a follow-up PR. The STD workflow involves: (1) defining test structure, markers, and documentation first, (2) implementing the actual test logic and removing the collection blocker in a subsequent PR.

Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 1776
File: libs/net/node_network.py:25-31
Timestamp: 2025-08-20T23:43:28.117Z
Learning: In the RedHatQE/openshift-virtualization-tests project, servolkov's team always uses bare metal (BM) clusters with IPv4 setup in their testing environment, making defensive checks for IPv4 data presence potentially redundant in their networking code.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 3371
File: scripts/tests_analyzer/compare_coderabbit_decisions.py:199-289
Timestamp: 2026-01-13T10:06:14.822Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep pagination loops inline rather than extracting them into generic helper functions when the loops have different URL patterns and unique post-processing logic, as the inline approach improves readability and makes each endpoint's behavior more explicit.

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 1160
File: tests/storage/storage_migration/test_mtc_storage_class_migration.py:165-176
Timestamp: 2025-06-17T07:45:37.776Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers explicit fixture parameters over composite fixtures in test methods, even when there are many parameters, as they find this approach more readable and maintainable for understanding test dependencies.

Learnt from: jpeimer
Repo: RedHatQE/openshift-virtualization-tests PR: 3571
File: tests/storage/storage_migration/utils.py:158-167
Timestamp: 2026-01-25T13:18:26.819Z
Learning: In the openshift-virtualization-tests repository, user jpeimer prefers to avoid nitpicky style changes (e.g., removing `.keys()` from dict membership checks) because verifying every change is expensive. Be cautious about suggesting low-impact stylistic improvements that require verification overhead.

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:24-64
Timestamp: 2025-06-23T19:28:20.281Z
Learning: In OpenShift Virtualization mass machine type transition tests, the machine type glob pattern "pc-q35-rhel8.*.*" is intentionally hard-coded in the kubevirt_api_lifecycle_automation_job as it's used only once for this specific test case, with plans to update it in the future if the job needs to support other machine types.

Learnt from: RoniKishner
Repo: RedHatQE/openshift-virtualization-tests PR: 1411
File: utilities/os_utils.py:246-279
Timestamp: 2025-07-22T17:13:59.166Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, CentOS preferences follow the format "centos-stream<version>" (e.g., "centos-stream9", "centos-stream10"). The generate_instance_type_centos_os_matrix function correctly uses regex to extract numeric versions and constructs the latest version string in the same format as the input preferences for proper comparison.

Learnt from: akri3i
Repo: RedHatQE/openshift-virtualization-tests PR: 1210
File: tests/virt/cluster/general/mass_machine_type_transition_tests/conftest.py:24-64
Timestamp: 2025-06-23T19:28:20.281Z
Learning: In OpenShift Virtualization mass machine type transition tests, the 2-minute timeout (TIMEOUT_2MIN) is sufficient for the kubevirt_api_lifecycle_automation_job because it only tests with one VM at a time, not multiple VMs simultaneously.

Learnt from: SiboWang1997
Repo: RedHatQE/openshift-virtualization-tests PR: 1669
File: utilities/virt.py:2645-2649
Timestamp: 2025-08-25T08:59:47.233Z
Learning: In OpenShift Virtualization tests with Windows OS matrix, Windows VM reboots reach the "Running" state within 10 seconds, making the default wait_until_running_timeout of 4 minutes more than sufficient for guest reboot scenarios in utilities/virt.py.

Learnt from: OhadRevah
Repo: RedHatQE/openshift-virtualization-tests PR: 3360
File: tests/observability/metrics/test_vms_metrics.py:95-117
Timestamp: 2026-01-19T13:49:54.850Z
Learning: In tests/observability/metrics/test_vms_metrics.py, the vm_in_starting_state fixture uses an intentional time.sleep(30) after vm.start() to capture the kubevirt_vm_starting_status_last_transition_timestamp_seconds metric during a transient period. The fixed sleep is preferred over TimeoutSampler status polling because: (1) different storage classes behave differently and the exact status is not relevant, (2) the metric needs to be triggered during a time window regardless of status, and (3) 30 seconds is sufficient and more efficient than waiting up to 3 minutes for a specific status.

Learnt from: vsibirsk
Repo: RedHatQE/openshift-virtualization-tests PR: 2045
File: tests/virt/cluster/vm_lifecycle/conftest.py:46-47
Timestamp: 2025-09-15T06:49:53.478Z
Learning: In the openshift-virtualization-tests repo, large fixture refactoring efforts like the golden image data source migration are handled incrementally by directory/team ownership. The virt/cluster directory is handled separately from virt/node, tests/infra, tests/storage, etc., with each area managed by relevant teams in follow-up PRs.

rnetser · 2026-03-22T13:24:48Z

/approve
/lgtm

…0s to 10 minutes (#4175) Cherry-pick from main branch, original PR: #3972, PR owner: Ahmad-Hafe

openshift-virtualization-qe-bot-5 · 2026-03-25T12:58:09Z

Cherry-picked PR CherryPicked: [cnv-4.20] Increase VolumeSnapshot wait timeout from 240s to 10 minutes into cnv-4.19: #4276

openshift-virtualization-qe-bot-5 · 2026-03-25T13:42:28Z

New container for quay.io/openshift-cnv/openshift-virtualization-tests:cnv-4.20 published

…0s to 10 minutes (#4276) Cherry-pick from `cnv-4.20` branch, original PR: #4175, PR owner: Ahmad-Hafe Co-authored-by: Ahmad Hafe <ahafe@redhat.com>

github-actions bot added the sig-storage label Mar 17, 2026

openshift-virtualization-qe-bot-5 requested a review from vsibirsk March 17, 2026 09:39

openshift-virtualization-qe-bot-5 assigned Ahmad-Hafe Mar 17, 2026

openshift-virtualization-qe-bot-5 mentioned this pull request Mar 17, 2026

CherryPicked: [cnv-4.20] Increase VolumeSnapshot wait timeout from 240s to 10 minutes - 4175 #4176

Closed

openshift-virtualization-qe-bot-5 requested a review from RoniKishner March 17, 2026 09:39

openshift-virtualization-qe-bot-5 added the branch-cnv-4.20 label Mar 17, 2026

openshift-virtualization-qe-bot-5 requested a review from geetikakay March 17, 2026 09:39

openshift-virtualization-qe-bot-5 added the size/XS label Mar 17, 2026

openshift-virtualization-qe-bot-5 requested review from dshchedr and rnetser March 17, 2026 09:39

openshift-virtualization-qe-bot-3 added the cherry-pick-cnv-4.19 label Mar 17, 2026

Ahmad-Hafe force-pushed the increase_timeout_test_data_import_cron_garbage_collection_cherrypick branch from 2b1b851 to 1b12cf4 Compare March 17, 2026 10:03

openshift-virtualization-qe-bot-4 added the needs-rebase label Mar 17, 2026

openshift-virtualization-qe-bot-2 added the lgtm-josemacassan label Mar 18, 2026

openshift-virtualization-qe-bot-2 added the lgtm-kshvaika label Mar 18, 2026

Ahmad-Hafe force-pushed the increase_timeout_test_data_import_cron_garbage_collection_cherrypick branch from 1b12cf4 to 5039b65 Compare March 18, 2026 20:43

openshift-virtualization-qe-bot-5 removed lgtm-josemacassan lgtm-kshvaika needs-rebase labels Mar 18, 2026

openshift-virtualization-qe-bot added tox:verify-tc-requirement-polarion:running D/S Testing and removed tox:verify-tc-requirement-polarion:running D/S Testing labels Mar 18, 2026

openshift-virtualization-qe-bot added the tox:verify-tc-requirement-polarion:passed D/S Testing label Mar 18, 2026

openshift-virtualization-qe-bot-2 added the needs-rebase label Mar 18, 2026

Increase VolumeSnapshot wait timeout from 240s to 10 minutes

030a146

Ahmad-Hafe force-pushed the increase_timeout_test_data_import_cron_garbage_collection_cherrypick branch from 5039b65 to 030a146 Compare March 22, 2026 09:37

openshift-virtualization-qe-bot-4 removed the needs-rebase label Mar 22, 2026

openshift-virtualization-qe-bot-2 added the lgtm-jpeimer label Mar 22, 2026

openshift-virtualization-qe-bot added the verified label Mar 22, 2026

coderabbitai bot reviewed Mar 22, 2026

View reviewed changes

Comment thread utilities/storage.py

openshift-virtualization-qe-bot added the commented-coderabbitai[bot] label Mar 22, 2026

openshift-virtualization-qe-bot-4 added the commented-Ahmad-Hafe label Mar 22, 2026

openshift-virtualization-qe-bot-2 added lgtm-rnetser approved-rnetser labels Mar 22, 2026

openshift-virtualization-qe-bot-4 added the needs-rebase label Mar 23, 2026

rnetser merged commit 2390f0b into RedHatQE:cnv-4.20 Mar 25, 2026
15 of 16 checks passed

This was referenced Mar 25, 2026

[4.20] Storage: replace repetitive code with get_dv_size_from_datasource fuction #4218

Merged

Storage: Change Cirros images for RHEL from DataSource into upgrade tests. #2917

Open

openshift-virtualization-qe-bot-5 pushed a commit that referenced this pull request Mar 25, 2026

CherryPicked: [cnv-4.20] Increase VolumeSnapshot wait timeout from 24…

78750d8

…0s to 10 minutes (#4175) Cherry-pick from main branch, original PR: #3972, PR owner: Ahmad-Hafe

cnv-tests-github-webhook-dollierp bot mentioned this pull request Mar 25, 2026

CherryPicked: [cnv-4.19] Increase VolumeSnapshot wait timeout from 240s to 10 minutes #4276

Merged

Conversation

Ahmad-Hafe commented Mar 17, 2026

Uh oh!

coderabbitai bot commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-virtualization-qe-bot-5 commented Mar 17, 2026

Welcome! 🎉

🔄 Automatic Actions

📋 Available Commands

PR Status Management

Review & Approval

Testing & Validation

Container Operations

Cherry-pick Operations

Label Management

✅ Merge Requirements

📊 Review Process

💡 Tips

Uh oh!

Ahmad-Hafe commented Mar 17, 2026

Uh oh!

openshift-virtualization-qe-bot-3 commented Mar 17, 2026

Uh oh!

Ahmad-Hafe commented Mar 17, 2026

Uh oh!

josemacassan commented Mar 18, 2026

Uh oh!

kshvaika commented Mar 18, 2026

Uh oh!

Ahmad-Hafe commented Mar 18, 2026

Uh oh!

Ahmad-Hafe commented Mar 18, 2026

Uh oh!

jpeimer commented Mar 22, 2026

Uh oh!

Ahmad-Hafe commented Mar 22, 2026

Uh oh!

openshift-virtualization-qe-bot-3 commented Mar 22, 2026

Uh oh!

Uh oh!

coderabbitai bot commented Mar 22, 2026

Uh oh!

rnetser commented Mar 22, 2026

Uh oh!

Uh oh!

openshift-virtualization-qe-bot-5 commented Mar 25, 2026

Uh oh!

openshift-virtualization-qe-bot-5 commented Mar 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

coderabbitai bot commented Mar 17, 2026 •

edited

Loading