Skip to content

CherryPicked: [cnv-4.19] Increase VolumeSnapshot wait timeout from 240s to 10 minutes#4276

Open
cnv-tests-github-webhook-dollierp[bot] wants to merge 1 commit intocnv-4.19from
CherryPicked-increase_timeout_test_data_import_cron_garbage_collection_cherrypick-F6sUy
Open

CherryPicked: [cnv-4.19] Increase VolumeSnapshot wait timeout from 240s to 10 minutes#4276
cnv-tests-github-webhook-dollierp[bot] wants to merge 1 commit intocnv-4.19from
CherryPicked-increase_timeout_test_data_import_cron_garbage_collection_cherrypick-F6sUy

Conversation

@cnv-tests-github-webhook-dollierp
Copy link
Copy Markdown

Cherry-pick from cnv-4.20 branch, original PR: #4175, PR owner: Ahmad-Hafe

…0s to 10 minutes (#4175)

Cherry-pick from main branch, original PR:
#3972, PR
owner: Ahmad-Hafe
@openshift-virtualization-qe-bot-5
Copy link
Copy Markdown

Report bugs in Issues

Welcome! 🎉

This pull request will be automatically processed with the following features:

🔄 Automatic Actions

  • Reviewer Assignment: Reviewers are automatically assigned based on the OWNERS file in the repository root
  • Size Labeling: PR size labels (XS, S, M, L, XL, XXL) are automatically applied based on changes
  • Issue Creation: A tracking issue is created for this PR and will be closed when the PR is merged or closed
  • Branch Labeling: Branch-specific labels are applied to track the target branch
  • Auto-verification: Auto-verified users have their PRs automatically marked as verified
  • Labels: Enabled categories: branch, can-be-merged, cherry-pick, has-conflicts, hold, needs-rebase, size, verified, wip

📋 Available Commands

PR Status Management

  • /wip - Mark PR as work in progress (adds WIP: prefix to title)
  • /wip cancel - Remove work in progress status
  • /hold - Block PR merging (approvers only)
  • /hold cancel - Unblock PR merging
  • /verified - Mark PR as verified
  • /verified cancel - Remove verification status
  • /reprocess - Trigger complete PR workflow reprocessing (useful if webhook failed or configuration changed)
  • /regenerate-welcome - Regenerate this welcome message

Review & Approval

  • /lgtm - Approve changes (looks good to me)
  • /approve - Approve PR (approvers only)
  • /assign-reviewers - Assign reviewers based on OWNERS file
  • /assign-reviewer @username - Assign specific reviewer
  • /check-can-merge - Check if PR meets merge requirements

Testing & Validation

  • /retest tox - Run Python test suite with tox
  • /retest build-container - Rebuild and test container image
  • /retest verify-bugs-are-open - verify-bugs-are-open
  • /retest all - Run all available tests

Container Operations

  • /build-and-push-container - Build and push container image (tagged with PR number)
    • Supports additional build arguments: /build-and-push-container --build-arg KEY=value

Cherry-pick Operations

  • /cherry-pick <branch> - Schedule cherry-pick to target branch when PR is merged
    • Multiple branches: /cherry-pick branch1 branch2 branch3

Label Management

  • /<label-name> - Add a label to the PR
  • /<label-name> cancel - Remove a label from the PR

✅ Merge Requirements

This PR will be automatically approved when the following conditions are met:

  1. Approval: /approve from at least one approver
  2. LGTM Count: Minimum 2 /lgtm from reviewers
  3. Status Checks: All required status checks must pass
  4. No Blockers: No wip, hold, has-conflicts labels and PR must be mergeable (no conflicts)
  5. Verified: PR must be marked as verified

📊 Review Process

Approvers and Reviewers

Approvers:

  • dshchedr
  • myakove
  • rnetser
  • vsibirsk

Reviewers:

  • RoniKishner
  • dshchedr
  • geetikakay
  • rnetser
  • vsibirsk
Available Labels
  • hold
  • verified
  • wip
  • lgtm
  • approve
AI Features
  • Cherry-Pick Conflict Resolution: Enabled (claude/claude-opus-4-6[1m])

💡 Tips

  • WIP Status: Use /wip when your PR is not ready for review
  • Verification: The verified label is automatically removed on each new commit
  • Cherry-picking: Cherry-pick labels are processed when the PR is merged
  • Container Builds: Container images are automatically tagged with the PR number
  • Permission Levels: Some commands require approver permissions
  • Auto-verified Users: Certain users have automatic verification and merge privileges

For more information, please refer to the project documentation or contact the maintainers.

@openshift-virtualization-qe-bot-3
Copy link
Copy Markdown
Contributor

/retest all

Auto-triggered: Files in this PR were modified by merged PR #4225.

Overlapping files

utilities/storage.py

@jpeimer jpeimer changed the title CherryPicked: [cnv-4.19] CherryPicked: [cnv-4.20] Increase VolumeSnapshot wait timeout from 240s to 10 minutes CherryPicked: [cnv-4.19] Increase VolumeSnapshot wait timeout from 240s to 10 minutes Mar 29, 2026
@jpeimer
Copy link
Copy Markdown
Contributor

jpeimer commented Mar 29, 2026

/approve
/lgtm

@Ahmad-Hafe
Copy link
Copy Markdown
Contributor

/verified
on psi

@Ahmad-Hafe
Copy link
Copy Markdown
Contributor

/cherry-pick cnv-4.18

@openshift-virtualization-qe-bot-2
Copy link
Copy Markdown
Contributor

Cherry-pick requested for PR: CherryPicked: [cnv-4.19] Increase VolumeSnapshot wait timeout from 240s to 10 minutes by user Ahmad-Hafe
Adding label/s cherry-pick-cnv-4.18 for automatic cheery-pick once the PR is merged

@ema-aka-young
Copy link
Copy Markdown
Contributor

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants