[1LP][WIPTEST] Update rhevm template kwargs, handle disk attachments#389
[1LP][WIPTEST] Update rhevm template kwargs, handle disk attachments#389mshriver wants to merge 1 commit intoRedHatQE:masterfrom
Conversation
| def add_disk(self, storage_domain=None, size=None, interface='VIRTIO', format=None, | ||
| active=True): | ||
| def add_disk(self, storage_domain=None, size=None, interface='virtio', format='cow', | ||
| active=True, sparse=True, name=None): |
There was a problem hiding this comment.
This default is coming from ovirt's defaults for types.Disk instantiation. Leaving it as None to allow rhv to name the disk, haven't tested what will happen if we explicitly pass empty string.
There was a problem hiding this comment.
I split this into #390 if you want to continue discussion.
| storage_domains=[types.StorageDomain(name=storage_domain)]), | ||
| interface=getattr(types.DiskInterface, interface), | ||
| storage_domains=[types.StorageDomain(name=storage_domain)], | ||
| sparse=bool(sparse)), |
There was a problem hiding this comment.
it should already be bool
There was a problem hiding this comment.
it should, but there's no type validation otherwise. I can remove though and just pass through what we get.
There was a problem hiding this comment.
I like that type validation. It will throw error right there, before performing operations with incorrect values.
izapolsk
changed the title
| disk_attachments (optional) -- list of dicts defining (name (partial), format, sparse) | ||
| name of template disks will be partial matched | ||
| format defaults to COW | ||
| sparse defaults to True (thin provisioning) |
| disk_attach = types.DiskAttachment( | ||
| disk=types.Disk(format=types.DiskFormat(format), | ||
| disk=types.Disk(name=str(name), | ||
| format=types.DiskFormat(format.lower()), |
There was a problem hiding this comment.
What happens when size or storage_domain is passed None?
draft state add_disk kwargs for name/format/sparse updated disk_attachments handling for template deploy. needs some consideration of the tradeoffs, and whether the kwarg should contain the attachments that should exist - or just modifications to attachments on the template that match by name.
mshriver
force-pushed
the
rhevm-thick-deploy-args
branch
from
0bd1bcf to
30bd585
Compare
5 participants
draft state, reader beware
add_disk kwargs for name/format/sparse updated
disk_attachments handling for template deploy. needs some consideration of the tradeoffs, and whether the kwarg should contain the attachments that should exist - or just modifications to attachments on the template that match by name.