feat(Logging): add BepisLoader version logging to chainloader startup#31
feat(Logging): add BepisLoader version logging to chainloader startup#31
Conversation
|
Download the artifacts for this pull request: |
| /// Gets the BepisLoader version if available. | ||
| /// </summary> | ||
| /// <returns>The version string, or null if BepisLoader is not found.</returns> | ||
| public static Version GetBepisLoaderVersion() |
There was a problem hiding this comment.
isn't there a Utils.BepisLoaderVersion or whatever
There was a problem hiding this comment.
oh wait I see its bepisloader not bepinex version. I mean I don't like this function in this place. I don't think we should be modifying bepinex core unless we have to
There was a problem hiding this comment.
the logger is in bepinex core and all the sys/env info is printed at the top. So this would be the appropriate place to do it. Alternative would be to put it in the Shim but it would get buried under other logs.
There was a problem hiding this comment.
I mean shim already prints it if you have the option to change window title technically. and yeah I think it makes more sense to do it there.
|
closing this in favor of ResoniteModding/BepInExResoniteShim#19 |
2 participants
Add utility method to detect BepisLoader assembly and retrieve its version, then log this information during chainloader initialization.