Skip to content

feat(Logging): add BepisLoader version logging to chainloader startup #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hazre wants to merge 1 commit into from
Closed

feat(Logging): add BepisLoader version logging to chainloader startup #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions BepInEx.Core/Utility.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,24 @@ public static class Utility
SemanticVersioning.Version.Parse(MetadataHelper.GetAttributes<AssemblyInformationalVersionAttribute>(typeof(Utility).Assembly)[0]
.InformationalVersion);

/// <summary>
/// Gets the BepisLoader version if available.
/// </summary>
/// <returns>The version string, or null if BepisLoader is not found.</returns>
public static Version GetBepisLoaderVersion()
Copy link

@art0007i art0007i Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't there a Utils.BepisLoaderVersion or whatever

Copy link

@art0007i art0007i Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait I see its bepisloader not bepinex version. I mean I don't like this function in this place. I don't think we should be modifying bepinex core unless we have to

Copy link
Member Author

@hazre hazre Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the logger is in bepinex core and all the sys/env info is printed at the top. So this would be the appropriate place to do it. Alternative would be to put it in the Shim but it would get buried under other logs.

Copy link

@art0007i art0007i Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean shim already prints it if you have the option to change window title technically. and yeah I think it makes more sense to do it there.

{
try
{
var bepisLoaderAsm = AppDomain.CurrentDomain.GetAssemblies()
.FirstOrDefault(a => a.GetName().Name == "BepisLoader");
return bepisLoaderAsm?.GetName().Version;
}
catch
{
return null;
}
}

private const string TRUSTED_PLATFORM_ASSEMBLIES = "TRUSTED_PLATFORM_ASSEMBLIES";
private static bool? sreEnabled;

Expand Down
6 changes: 6 additions & 0 deletions BepInEx.Preloader.Core/Logging/ChainloaderLogHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ public static void PrintLogInfo(ManualLogSource log)
Logger.Log(LogLevel.Info, $"System platform: {GetPlatformString()}");
Logger.Log(LogLevel.Info,
$"Process bitness: {(PlatformUtils.ProcessIs64Bit ? "64-bit (x64)" : "32-bit (x86)")}");

var bepisLoaderVersion = Utility.GetBepisLoaderVersion();
if (bepisLoaderVersion != null)
Logger.Log(LogLevel.Info, $"Loader: BepisLoader {bepisLoaderVersion}");
else
Logger.Log(LogLevel.Info, "Loader: BepisLoader not found, version unknown");
}

private static string GetPlatformString()
Expand Down
Loading