Skip to content

fix: forgot password email DDP method doesn't have strict rate limits - #41857

Open
dionisio-bot[bot] wants to merge 1 commit into
release-8.1.8from
backport-8.1.8-41699
Open

fix: forgot password email DDP method doesn't have strict rate limits#41857
dionisio-bot[bot] wants to merge 1 commit into
release-8.1.8from
backport-8.1.8-41699

Conversation

@dionisio-bot

@dionisio-bot dionisio-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Backport of #41699

Review in cubic

@dionisio-bot
dionisio-bot Bot requested a review from a team as a code owner August 19, 2026 01:49
@changeset-bot

changeset-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8ea8fb5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dionisio-bot

dionisio-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release-8.1.8@2ed619d). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-8.1.8   #41857   +/-   ##
================================================
  Coverage                 ?   70.76%           
================================================
  Files                    ?     3170           
  Lines                    ?   110464           
  Branches                 ?    19888           
================================================
  Hits                     ?    78172           
  Misses                   ?    30235           
  Partials                 ?     2057           
Flag Coverage Δ
e2e 60.27% <ø> (?)
e2e-api 48.13% <50.00%> (?)
unit 71.74% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

📦 Docker Image Size Report

📉 Changes

Service Current Baseline Change Percent
sum of all images 1.1GiB 1.1GiB -27MiB
rocketchat 358MiB 293MiB +66MiB
omnichannel-transcript-service 132MiB 153MiB -22MiB
queue-worker-service 132MiB 153MiB -22MiB
ddp-streamer-service 126MiB 142MiB -16MiB
account-service 113MiB 122MiB -9.1MiB
authorization-service 111MiB 122MiB -12MiB
presence-service 111MiB 123MiB -13MiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["07/14 23:46", "07/15 23:00", "07/16 23:06", "07/17 23:10", "07/18 05:28", "07/19 20:26", "07/20 21:28", "07/21 21:59", "07/22 23:40", "07/23 20:29", "07/24 17:16", "07/27 19:25", "07/28 15:53", "07/29 23:08", "07/30 23:27", "07/31 19:45", "08/03 22:17", "08/04 23:58", "08/05 13:15", "08/07 22:40", "08/08 02:56", "08/10 20:36", "08/11 23:03", "08/12 23:09", "08/13 22:15", "08/14 21:17", "08/15 00:05", "08/17 23:12", "08/18 11:44", "08/19 00:24", "08/19 02:18 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.11]
  line "authorization-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.11]
  line "ddp-streamer-service" [0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.14, 0.12]
  line "omnichannel-transcript-service" [0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.13]
  line "presence-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.11]
  line "queue-worker-service" [0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.15, 0.13]
  line "rocketchat" [0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.28, 0.28, 0.28, 0.28, 0.28, 0.28, 0.28, 0.28, 0.28, 0.28, 0.28, 0.28, 0.28, 0.28, 0.28, 0.28, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.29, 0.35]
Loading

Statistics (last 30 days):

  • 📊 Average: 2.1GiB
  • ⬇️ Minimum: 1.4GiB
  • ⬆️ Maximum: 2.3GiB
  • 🎯 Current PR: 1.1GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-41857
  • Baseline: develop
  • Timestamp: 2026-08-19 02:18:01 UTC
  • Historical data points: 30

Updated: Wed, 19 Aug 2026 02:18:01 GMT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Used to inform backported PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant