Skip to content

fix: forgot password email DDP method doesn't have strict rate limits #41857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julio-rocketchat merged 1 commit into from
Aug 19, 2026
+18 −0
Merged

fix: forgot password email DDP method doesn't have strict rate limits #41857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-ends-refuse.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Adds per-client rate limiting to the unauthenticated sendForgotPasswordEmail method, matching the REST users.forgotPassword endpoint
13 changes: 13 additions & 0 deletions apps/meteor/server/methods/sendForgotPasswordEmail.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import type { ServerMethods } from '@rocket.chat/ddp-client';
import { Users } from '@rocket.chat/models';
import { Accounts } from 'meteor/accounts-base';
import { check } from 'meteor/check';
import { DDPRateLimiter } from 'meteor/ddp-rate-limiter';
import { Meteor } from 'meteor/meteor';

import { settings } from '../../app/settings/server';
Expand Down Expand Up @@ -44,3 +45,15 @@ Meteor.methods<ServerMethods>({
return sendForgotPasswordEmail(to);
},
});

DDPRateLimiter.addRule(
{
type: 'method',
name: 'sendForgotPasswordEmail',
clientAddress() {
return true;
},
},
10,
60000,
);
Loading