feat: replace hardcoded jobs with configurable actions#2351
Open
minottic wants to merge 4 commits into
Open
Conversation
This applies both to cart and dataset actions
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- In several places (e.g. building
actionItemsinDatasetTableActionsComponentandBatchViewComponent) you rely onas ActionItemDataset[]/as UserProfile; consider tightening the selector types (or introducing a typed facade) so you can avoid these casts and catch mismatches at compile time. - The
{ success: boolean }payload foractionFinishedis duplicated across multiple components; introducing a shared interface/type (and possibly centralizing the success-handling logic, e.g. driven offactionSuccessActionin an effect) would reduce duplication and make it easier to evolve the contract later.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In several places (e.g. building `actionItems` in `DatasetTableActionsComponent` and `BatchViewComponent`) you rely on `as ActionItemDataset[]` / `as UserProfile`; consider tightening the selector types (or introducing a typed facade) so you can avoid these casts and catch mismatches at compile time.
- The `{ success: boolean }` payload for `actionFinished` is duplicated across multiple components; introducing a shared interface/type (and possibly centralizing the success-handling logic, e.g. driven off `actionSuccessAction` in an effect) would reduce duplication and make it easier to evolve the contract later.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
Author
|
after this PR I believe another enhancement of configurable-actions would be to allow for shared blocks, in particular the variables one. This way the config can stay slimmer since often variables in multiple actions inside the same config key are shared |
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By setting
batchActionsEnabledandbatchActionsin config.json it renders them as actions in the overview page and in the cart (common ones are preserved)Motivation
This facilitates facilities to set custom actions in the cart and in particular helps us in adding new workflows, delete and restore ones.
This is an example of the config
Changes:
Tests included
Documentation
official documentation info
If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included
Backend version
Summary by Sourcery
Replace hardcoded archive/retrieve dataset jobs with configurable batch actions and integrate them into the datasets overview and batch views.
New Features:
Bug Fixes:
Enhancements:
Documentation:
Tests: