This repository was archived by the owner on Mar 12, 2023. It is now read-only.
Conversation
This is a first draft that implements this class. It is responsible to obtain connections to the DB and make sure the expected tables exist.
Python 2 does not have tempfile.TemporaryDirectory
This class duplicates a Pandas DataFrame into a temporary table inside a sqlite database. The table is disposed once it is not needed any more.
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
==========================================
- Coverage 95.66% 93.03% -2.63%
==========================================
Files 9 13 +4
Lines 461 646 +185
==========================================
+ Hits 441 601 +160
- Misses 20 45 +25
|
Closed
This is the default in Python 3 anyways, Python 2 uses a different default that forces transactions to be committed immediatelly.
This makes it safe in Python 2 as well
The version before failed when it is executed on the same database twice. Added test to ensure this behaviour is tested and fixed the bug.
This function is obsolete since tests are discovered by pytest
fa-me
reviewed
Mar 31, 2019
|
|
||
| storage = Storage(self.db_file) | ||
| df_cash = self._read_dummy_file_dkbcash_small() | ||
| df_visa = self._read_dummy_file_dkbcash_small() |
Collaborator
There was a problem hiding this comment.
should say self._read_dummy_file_dkbvisa_small()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not review or merge yet. This will heavily change.
originin DataFrames from TextImporter?TemporaryDatabasedatabasesubpackage, see WIP new directory structure #47Closes #30.