Skip to content
This repository was archived by the owner on Mar 12, 2023. It is now read-only.

WIP new directory structure#47

Open
fa-me wants to merge 1 commit intomasterfrom
new-dir-structure
Open

WIP new directory structure#47
fa-me wants to merge 1 commit intomasterfrom
new-dir-structure

Conversation

@fa-me
Copy link
Copy Markdown
Collaborator

@fa-me fa-me commented Feb 16, 2019

Suggestions:

  • tests in separate subpackage (within the package according to this guide
  • subpackage for static bank specific definitions
  • subpackage for visualization, frontend
  • everything else in root

to be discussed and then implemented here

closes #32

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 16, 2019

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   99.38%   99.38%           
=======================================
  Files          10       10           
  Lines         484      484           
=======================================
  Hits          481      481           
  Misses          3        3

@fa-me
Copy link
Copy Markdown
Collaborator Author

fa-me commented Feb 16, 2019

@Sh4pe have a look. What do you think will be a good time to do this without having to merge too much. Maybe wait until the open PRs are merged?

@Sh4pe
Copy link
Copy Markdown
Owner

Sh4pe commented Feb 17, 2019

@Sh4pe have a look. What do you think will be a good time to do this without having to merge too much. Maybe wait until the open PRs are merged?

This proposal looks good to me. And in #39, I'll add another submodule called database on the same level as parse and dash_viz if you are okay with it.

I think that any time soon would be a good time, after the current PRs are merged. Should not be too much of a hassle anyways since we don't have very many files yet.

@Sh4pe Sh4pe assigned Sh4pe and fa-me and unassigned Sh4pe Feb 17, 2019
@Sh4pe Sh4pe added this to the 0.1 milestone Feb 17, 2019
@Sh4pe Sh4pe mentioned this pull request Mar 2, 2019
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define directory layout

2 participants