Migrate React Native sample to Expo prebuild by kieran-osgood-shopify · Pull Request #297 · Shopify/checkout-kit

kieran-osgood-shopify · 2026-06-18T10:19:30Z

Stack Context

This PR is stacked on top of #322, which moves the RN iOS bridge tests into a dedicated XcodeGen/CocoaPods integration app before this PR deletes the generated Expo sample native projects.

Summary

Lockfile maintenance doing some work on the git diff here:

migrate the React Native sample to Expo 56 prebuild/dev-client
replace sample-only native dependencies with Expo APIs/packages
delete committed generated sample native projects and add a unified dev rn prebuild command with --local support
make Expo prebuild always run clean so generated native projects are reproducible
align Expo dependency versions with expo install --check where the Shopify package proxy has the recommended version available
remove redundant direct React Native CLI/dev dependencies and legacy mocks

Validation

dev rn test ios
dev rn test android
dev rn test js
dev rn lint
git diff --check

Previous validation from this branch before restacking:

dev rn prebuild android --local
dev rn prebuild ios --local
pnpm exec expo install --check from platforms/react-native/sample
pnpm dlx expo-doctor from platforms/react-native/sample was attempted; remaining failures are from expo-doctor shelling out to npm explain, which is blocked by the workspace npm wrapper/minimum dependency age enforcement under shadowenv

Notes

This intentionally stops before CI/docs follow-up work.
Generated platforms/react-native/sample/ios and platforms/react-native/sample/android are ignored and regenerated via clean Expo prebuild.
expo, expo-build-properties, and expo-font are pinned to the newest SDK 56 versions currently available through the Shopify package proxy, and are excluded from Expo dependency validation until the proxy catches up to Expo's latest recommendations.

kieran-osgood-shopify · 2026-06-18T10:19:46Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Migrate React Native sample to Expo prebuild #297 👈 (View in Graphite)
Move RN iOS tests into XcodeGen integration app #322
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

kieran-osgood-shopify · 2026-06-23T11:44:06Z

          working-directory: platforms/react-native/sample

-      - name: Verify iOS lockfile uses published native SDK
-        run: scripts/check_published_podfile_lock sample/ios/Podfile.lock


This is now inlined into the platforms/react-native/sample/scripts/build_ios script

Assisted-By: devx/fb34cb30-8090-438b-b735-1d8f8eb128a6

Assisted-By: devx/741457bb-fda8-43d5-b35b-2e08c409a2fe

Assisted-By: devx/2d0344dc-43dd-4535-baf2-409ff9e93de5

Assisted-By: devx/c25009c8-5a1d-4cb8-aee9-2dcf64902080

Assisted-By: devx/058cd5b9-f1cc-431b-b520-15657ace50f1

kieran-osgood-shopify · 2026-06-24T10:10:55Z

-    [],
-  );
+  useEffect(() => {
+    customerAccountManager.buildAuthorizationURL().then(setAuthorizationURL);


This shouldn't have been refactored from useMemo

kieran-osgood-shopify · 2026-06-24T10:12:04Z

  const updatedColors = getColors(
    appConfig.colorScheme,
-    Appearance.getColorScheme(),
+    Appearance.getColorScheme() ?? 'light',


we should probably extract a helper for this we have called it with the null coalsescing operation a number of times

kieran-osgood-shopify · 2026-06-24T10:12:45Z

+  getRandomBytes,
+} from 'expo-crypto';

-function base64URLEncode(buffer: ArrayBufferLike): string {


TODO; test customer authentication

kieran-osgood-shopify · 2026-06-24T10:13:33Z

        ).boolValue
    }

-    func testConfigureAcceleratedCheckoutsSetsSharedConfigsOnIOS16() throws {


i dont see why all these tests have changed

kieran-osgood-shopify · 2026-06-24T10:14:28Z

    // MARK: - RenderState

-    func testRenderStateSerialization_includesErrorReason() throws {
+    func testRenderStateSerialization_includesErrorReason() {


Again not sure why all these changes came in

kieran-osgood-shopify · 2026-06-24T10:21:00Z

+    window: {width: 390, height: 844, scale: 3, fontScale: 1},
+    screen: {width: 390, height: 844, scale: 3, fontScale: 1},
+  },
+  isIPhoneX_deprecated: false,


I dont see any reference to this being used - im not sure whether any of these mocks are actually necessary

kieran-osgood-shopify · 2026-06-24T10:21:45Z


 ```tsx
 import {ApolloClient, gql, ApolloProvider} from '@apollo/client';
-import {API_VERSION, STOREFRONT_DOMAIN, STOREFRONT_ACCESS_TOKEN} from '@env';


this didn't need to change

kieran-osgood-shopify · 2026-06-24T10:22:11Z

we should re-run pnpm dedupe to check whether theres anything we can trim off here

kieran-osgood-shopify · 2026-06-24T10:24:37Z

-    "react-native-vector-icons": "^10.3.0",
-    "react-native-webview": "^13.16.0"
-  },
-  "peerDependencies": {


is removal of the peerDeps a regression in how we resolve react-native / react version now?

kieran-osgood-shopify · 2026-06-24T10:31:26Z

+        : []),
+    ],
+  },
+  extra: {


i dont think we need this - we access all of the values from the expo .env rather than from Constants.expoConfig.extra

kieran-osgood-shopify · 2026-06-24T10:34:41Z

+  fs.copyFileSync(from, to);
+}
+
+function withIosLocalSdkPodfile(config) {


I'm not confident we actually need any of this? the only thing I believe we need to conditionally apply via podfile is the use local sdk pods

kieran-osgood-shopify · 2026-06-24T10:38:48Z

+    return mod;
+  });
+
+  return withEntitlementsPlist(config, mod => {


this is confusing - we already setup the entitlements in the app.config.js - so this seems duplicated

kieran-osgood-shopify · 2026-06-24T10:39:27Z

+}
+
+function withGeneratedLinks(config) {
+  config = withInfoPlist(config, mod => {


pretty sure this can be achieved with a ios.infoplist entry in the app.config.js

kieran-osgood-shopify · 2026-06-24T10:43:54Z

  debugImplementation(shopifySdkArtifact)

  testImplementation "junit:junit:4.13.2"
+  testImplementation "androidx.activity:activity:1.9.3"


double check these were necessary to add

kieran-osgood-shopify · 2026-06-24T10:44:49Z

-      - name: Verify iOS lockfile uses published native SDK
-        run: scripts/check_published_podfile_lock sample/ios/Podfile.lock
-
-      - name: Cache cocoapods


it'd be beneficial to bring back the caching

kieran-osgood-shopify force-pushed the cx-expo-prebuild-migration branch 4 times, most recently from fed581f to 525dc82 Compare June 19, 2026 13:23

kieran-osgood-shopify added the #gsd:50662 Rebase Checkout Kit on UCP label Jun 19, 2026

kieran-osgood-shopify force-pushed the cx-expo-prebuild-migration branch 3 times, most recently from 4e0e1bc to e8d8056 Compare June 23, 2026 10:20

kieran-osgood-shopify commented Jun 23, 2026

View reviewed changes

kieran-osgood-shopify added 7 commits June 23, 2026 18:09

Migrate React Native sample to Expo prebuild

881e894

Add unified React Native prebuild command

80e3d09

Assisted-By: devx/fb34cb30-8090-438b-b735-1d8f8eb128a6

Align Expo dependencies and remove pod install wrapper

9241a0e

Tighten React Native Expo migration scope

0efe5f5

Assisted-By: devx/741457bb-fda8-43d5-b35b-2e08c409a2fe

Migrate React Native Jest setup to Expo

7782700

Assisted-By: devx/2d0344dc-43dd-4535-baf2-409ff9e93de5

Trim React Native Expo migration scope

b386d2f

Assisted-By: devx/c25009c8-5a1d-4cb8-aee9-2dcf64902080

Verify iOS sample Podfile after Expo prebuild

ecf8970

Assisted-By: devx/058cd5b9-f1cc-431b-b520-15657ace50f1

kieran-osgood-shopify changed the base branch from main to graphite-base/297 June 23, 2026 17:21

kieran-osgood-shopify force-pushed the cx-expo-prebuild-migration branch from 1293856 to ecf8970 Compare June 23, 2026 17:21

kieran-osgood-shopify changed the base branch from graphite-base/297 to kieran-osgood/cx-expo-prebuild/rct-integration-tests June 23, 2026 17:21

kieran-osgood-shopify mentioned this pull request Jun 23, 2026

Move RN iOS tests into XcodeGen integration app #322

Open

kieran-osgood-shopify commented Jun 24, 2026

View reviewed changes

kieran-osgood-shopify changed the base branch from kieran-osgood/cx-expo-prebuild/rct-integration-tests to graphite-base/297 June 24, 2026 11:03

Uh oh!

Conversation

kieran-osgood-shopify commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Stack Context

Summary

Validation

Notes

Uh oh!

kieran-osgood-shopify commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kieran-osgood-shopify Jun 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

kieran-osgood-shopify commented Jun 18, 2026 •

edited

Loading

kieran-osgood-shopify commented Jun 18, 2026 •

edited

Loading

kieran-osgood-shopify Jun 24, 2026 •

edited

Loading