Move RN iOS tests into XcodeGen integration app#322
Open
kieran-osgood-shopify wants to merge 1 commit into
Open
Move RN iOS tests into XcodeGen integration app#322kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood-shopify wants to merge 1 commit into
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| @Suite("Protocol Relay Tests") | ||
| struct ProtocolRelayTests { | ||
| @Test func envelopeEncodesTypeAndWireCasePayload() throws { | ||
| final class ProtocolRelayTests: XCTestCase { |
Contributor
Author
There was a problem hiding this comment.
All the other tests are in XCTest so this just aligns it to the same test approach as other test files
React Native — Coverage Report
|
Package Size
Measured from the PR base SHA and PR head SHA. This comment reports package artifact sizes only; it is not a final app binary-size report. |
kieran-osgood-shopify
force-pushed
the
kieran-osgood/cx-expo-prebuild/rct-integration-tests
branch
2 times, most recently
from
81055f9 to
308872e
Compare
kieran-osgood-shopify
force-pushed
the
kieran-osgood/cx-expo-prebuild/rct-integration-tests
branch
from
308872e to
b129eb3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack Context
This is the first PR in a two-PR stack that separates React Native iOS test relocation from the Expo sample migration.
The idea here is to re-locate the test scheme so it's not coupled to the "sample" app
Migrating to expo leads to deleting the ios directory, so we want the ios test scheme to become stand alone
Stack:
What?
platforms/react-native/test/rct-integration-appas a small XcodeGen-generated CocoaPods host app for RN iOS tests.platforms/swift/Scripts/generate_xcode_projectssodev upgenerates the RN RCT integration app through the existing XcodeGen pipeline.dev rn test iosto run the Xcode/CocoaPods integration tests.Why?
The Expo migration deletes the committed generated React Native sample native projects. Before that happens, the RN-specific iOS behavioral coverage needs a stable home that is not inside generated sample output.
This keeps the tests running against the real React Native/CocoaPods integration until React Native SPM support is ready.
Validation
dev rn test iosdev rn test jsdev rn lintgit diff --check