[Protocol/Swift] Add support for ec_auth / ec_color_scheme#325
Merged
Conversation
0aa04fd to
6cb030e
Compare
ec_auth / ec_color_schemeec_auth / ec_color_scheme
Package Size
Measured from the PR base SHA and PR head SHA. This comment reports package artifact sizes only; it is not a final app binary-size report. |
11 tasks
kiftio
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Embedded Checkout Protocol spec defines
ec_authandec_color_schemequery parameters alongsideec_versionandec_delegate, but the protocol layer only emitted the latter two.Changes
ec_authandec_color_schemequery parameters fromEmbeddedCheckoutProtocol.url.url(for:delegations:)arguments with anOptionsstruct (delegations,colorScheme,auth) so the signature stays stable as the spec adds handshake parameters.Delegationtype sourced from the spec'sx-delegations— string-backed andExpressibleByStringLiteral, so known values are type-safe and unknown values round-trip.defaultDelegationsnow uses it.ec_color_schemea plainStringat the protocol boundary; the kit owns the curated color-scheme set.