Skip to content

[Protocol/Swift] Add support for ec_auth / ec_color_scheme#325

Merged
markmur merged 1 commit into
mainfrom
support/auth-color-scheme
Jun 25, 2026
Merged

[Protocol/Swift] Add support for ec_auth / ec_color_scheme#325
markmur merged 1 commit into
mainfrom
support/auth-color-scheme

Conversation

@markmur

@markmur markmur commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

The Embedded Checkout Protocol spec defines ec_auth and ec_color_scheme query parameters alongside ec_version and ec_delegate, but the protocol layer only emitted the latter two.

Changes

  • Emit ec_auth and ec_color_scheme query parameters from EmbeddedCheckoutProtocol.url.
  • Replace the url(for:delegations:) arguments with an Options struct (delegations, colorScheme, auth) so the signature stays stable as the spec adds handshake parameters.
  • Add a generated Delegation type sourced from the spec's x-delegations — string-backed and ExpressibleByStringLiteral, so known values are type-safe and unknown values round-trip. defaultDelegations now uses it.
  • Keep ec_color_scheme a plain String at the protocol boundary; the kit owns the curated color-scheme set.
  • Regenerate the public Swift API baseline.

@markmur markmur self-assigned this Jun 24, 2026
@markmur markmur force-pushed the support/auth-color-scheme branch from 0aa04fd to 6cb030e Compare June 24, 2026 12:00
@markmur markmur marked this pull request as ready for review June 24, 2026 12:04
@markmur markmur requested a review from a team as a code owner June 24, 2026 12:04
@markmur markmur changed the title [Protocol] Add support for ec_auth / ec_color_scheme [Protocol/Swift] Add support for ec_auth / ec_color_scheme Jun 24, 2026
@github-actions

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.66% (319/348) 87.86% (181/206) 100% (82/82)

@github-actions

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
Android release AAR 613.4 KiB 613.4 KiB 0 B

Measured from the PR base SHA and PR head SHA. This comment reports package artifact sizes only; it is not a final app binary-size report.

@markmur markmur merged commit 11962f5 into main Jun 25, 2026
51 checks passed
@markmur markmur deleted the support/auth-color-scheme branch June 25, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants