[Android] Move url encoding to protocol#324
Merged
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
691cd9c to
aba9849
Compare
ef79018 to
53488b2
Compare
Package Size
Measured from the PR base SHA and PR head SHA. This comment reports package artifact sizes only; it is not a final app binary-size report. |
11 tasks
markmur
reviewed
Jun 24, 2026
| */ | ||
| public fun url( | ||
| url: String, | ||
| delegations: List<String> = emptyList(), |
Contributor
There was a problem hiding this comment.
Just a heads up that I've changed this to an options struct argument for Swift in this PR to add support for colorScheme and auth. It scales better than adding new arguments for every param added to the spec
aba9849 to
a55876b
Compare
53488b2 to
9ae6451
Compare
9ae6451 to
bdd4542
Compare
13 tasks
bdd4542 to
afb8ce9
Compare
45bb9fb to
05c4f31
Compare
afb8ce9 to
d98a9b4
Compare
05c4f31 to
9716dc8
Compare
tiagocandido
approved these changes
Jun 25, 2026
d98a9b4 to
f4914e7
Compare
9716dc8 to
a75817c
Compare
Contributor
Author
a75817c to
f79b4c3
Compare
f4914e7 to
7bc20e2
Compare
13 tasks
7bc20e2 to
9cfe4ae
Compare
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What changes are you making?
Moves the responsibility of constructing ECP-compliant checkout URLs into
EmbeddedCheckoutProtocolitself via a newurl()function. Previously,UriExtensions.ktin the Android platform contained its own implementation ofappendEcpParamsthat manually managedec_versionandec_delegatequery parameters. That logic has been replaced with a call toEmbeddedCheckoutProtocol.url(), which now owns the canonical URL-building behaviour for the protocol.The new
EmbeddedCheckoutProtocol.url()function:ec_versionset toSPEC_VERSIONec_delegateas a comma-separated list of delegation stringsec_versionorec_delegatevalues before appending its own, making it idempotentThe
appendEcpParams()extension in the Android platform is simplified to delegate directly toEmbeddedCheckoutProtocol.url(), and the hardcodedspecVersionparameter is removed from all call sites.How to test
UriExtensionsTestsuite on Android and confirm all existingappendEcpParamstests pass.EmbeddedCheckoutProtocolTestsuite and confirm the newurl()tests pass, covering:ec_versionis appended andec_delegateis omitted when no delegations are providedec_delegateec_version/ec_delegatevalues are replaced (idempotency)delegationslist removes any pre-existingec_delegatevalueBefore you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/CHANGELOG.mdplatforms/swift/README.md(major version only)Releasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/CHANGELOG.mdplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.