Skip to content

[Android] Expose fulfillmentChange#340

Merged
kiftio merged 1 commit into
mainfrom
06-25-expose_fulfillmentchange_in_android
Jun 25, 2026
Merged

[Android] Expose fulfillmentChange#340
kiftio merged 1 commit into
mainfrom
06-25-expose_fulfillmentchange_in_android

Conversation

@kiftio

@kiftio kiftio commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

Adds support for the ec.fulfillment.change protocol event by introducing a fulfillmentChange notification descriptor to both EmbeddedCheckoutProtocol and CheckoutProtocol. This allows clients to register handlers for fulfillment change notifications and have them dispatched correctly when the event is received.

How to test

  1. Register a handler for CheckoutProtocol.fulfillmentChange on a CheckoutProtocol.Client instance.
  2. Send a message with method ec.fulfillment.change and verify the handler is invoked with the decoded Checkout payload.
  3. Run the existing and newly added unit tests:
    • fulfillmentChange descriptor has correct method — verifies the method string is ec.fulfillment.change
    • process dispatches ec fulfillment change to registered handler — verifies end-to-end dispatch
    • embedded checkout fulfillment change descriptor decodes checkout notifications — verifies payload decoding

Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

kiftio commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@kiftio kiftio changed the title expose fulfillmentChange in android [Android] Expose fulfillmentChange Jun 25, 2026
@kiftio kiftio marked this pull request as ready for review June 25, 2026 09:43
@kiftio kiftio requested a review from a team as a code owner June 25, 2026 09:43
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.66% (319/348) 87.86% (181/206) 100% (82/82)

@github-actions

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
Android release AAR 167.4 KiB 167.5 KiB +85 B

Measured from the PR base SHA and PR head SHA. This comment reports package artifact sizes only; it is not a final app binary-size report.

@kiftio kiftio force-pushed the 06-24-add_support_for_ec_auth_and_ec_color_scheme branch 2 times, most recently from 4c18156 to 57e1c0e Compare June 25, 2026 10:07
@kiftio kiftio force-pushed the 06-25-expose_fulfillmentchange_in_android branch 3 times, most recently from 0c18157 to c5523fb Compare June 25, 2026 10:44

kiftio commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jun 25, 11:07 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jun 25, 11:09 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jun 25, 11:25 AM UTC: @kiftio merged this pull request with Graphite.

@kiftio kiftio changed the base branch from 06-24-add_support_for_ec_auth_and_ec_color_scheme to graphite-base/340 June 25, 2026 11:07
@kiftio kiftio changed the base branch from graphite-base/340 to main June 25, 2026 11:07
@kiftio kiftio force-pushed the 06-25-expose_fulfillmentchange_in_android branch from c5523fb to f085665 Compare June 25, 2026 11:08
@kiftio kiftio merged commit 103fe88 into main Jun 25, 2026
33 checks passed
@kiftio kiftio deleted the 06-25-expose_fulfillmentchange_in_android branch June 25, 2026 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants