Skip to content

[Android] Ensure soft keyboard doesnt obscure pay button#342

Draft
kiftio wants to merge 1 commit into
mainfrom
06-25-ensure_soft_keyboard_doesnt_obscure_pay_button
Draft

[Android] Ensure soft keyboard doesnt obscure pay button#342
kiftio wants to merge 1 commit into
mainfrom
06-25-ensure_soft_keyboard_doesnt_obscure_pay_button

Conversation

@kiftio

@kiftio kiftio commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

What changes are you making?

Replaces the deprecated SOFT_INPUT_ADJUST_RESIZE soft input mode on the checkout dialog with SOFT_INPUT_ADJUST_NOTHING, and introduces explicit IME inset handling via WindowInsetsCompat. When the keyboard appears, the root view's bottom padding is adjusted to push checkout content up rather than relying on the window resizing.

The dialog layout has been migrated from a RelativeLayout root to a LinearLayout (checkoutKitRoot) so the toolbar and content container stack vertically. The container uses layout_height="0dp" with layout_weight="1" to fill remaining space. The background color from the configured color scheme is now applied to both the root LinearLayout and the inner RelativeLayout container.

The dialog window is set to MATCH_PARENT height only after show() is called, since window dimensions are only reliably applied at that point.


Before you merge

Important

  • I've added tests to support my implementation
  • I have read and agree with the Contribution Guidelines
  • I have read and agree with the Code of Conduct
  • I've updated the relevant platform README (platforms/swift/README.md and/or platforms/android/README.md)

Releasing a new Swift version?
  • I have bumped the version in ShopifyCheckoutKit.podspec
  • I have bumped the version in platforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swift
  • I have updated platforms/swift/CHANGELOG.md
  • I have updated the SwiftPM/CocoaPods version snippets in platforms/swift/README.md (major version only)
Releasing a new Embedded Checkout Protocol version?
  • I have bumped embeddedCheckoutProtocolAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated protocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.api if the public API changed
Releasing a new Android version?
  • I have bumped checkoutKitAndroid in platforms/android/gradle/libs.versions.toml
  • I have updated platforms/android/CHANGELOG.md
  • I have updated the Gradle/Maven version snippets in platforms/android/README.md

Tip

See the Contributing documentation for the full release process per platform.

kiftio commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@kiftio kiftio marked this pull request as ready for review June 25, 2026 10:46
@kiftio kiftio requested a review from a team as a code owner June 25, 2026 10:46
@kiftio kiftio changed the title ensure soft keyboard doesnt obscure pay button [Android] Ensure soft keyboard doesnt obscure pay button Jun 25, 2026
@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

React Native — Coverage Report

Lines Statements Branches Functions
Coverage: 92%
91.66% (319/348) 87.86% (181/206) 100% (82/82)

@github-actions

github-actions Bot commented Jun 25, 2026

Copy link
Copy Markdown

Package Size

Platform Artifact Base Head Delta
Android release AAR 167.5 KiB 168.1 KiB +659 B

Measured from the PR base SHA and PR head SHA. This comment reports package artifact sizes only; it is not a final app binary-size report.

@kiftio kiftio changed the base branch from 06-25-expose_fulfillmentchange_in_android to graphite-base/342 June 25, 2026 11:08
@kiftio kiftio force-pushed the graphite-base/342 branch from c5523fb to 103fe88 Compare June 25, 2026 11:26
@kiftio kiftio force-pushed the 06-25-ensure_soft_keyboard_doesnt_obscure_pay_button branch from f1fb763 to 4cbc3ec Compare June 25, 2026 11:26
@graphite-app graphite-app Bot changed the base branch from graphite-base/342 to main June 25, 2026 11:26
@kiftio kiftio force-pushed the 06-25-ensure_soft_keyboard_doesnt_obscure_pay_button branch 3 times, most recently from e011191 to 0865dbe Compare June 25, 2026 12:44
@kiftio kiftio marked this pull request as draft June 25, 2026 14:28
@kiftio kiftio force-pushed the 06-25-ensure_soft_keyboard_doesnt_obscure_pay_button branch from 0865dbe to 91f81d2 Compare June 25, 2026 15:22
@kiftio kiftio marked this pull request as ready for review June 25, 2026 15:25
@kiftio kiftio marked this pull request as draft June 25, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants