Please add system/account method#36
Open
base1217 wants to merge 3 commits into
Open
Conversation
Collaborator
|
Hi @base1217 , thanks a lot for your contribution! We will give it a look hopefully soon. |
Collaborator
|
Hi @base1217 .. thanks for your patience, we are going to look at your PR now. |
Collaborator
|
Please add this to the unreleased section of
|
dillu24
requested changes
Sep 7, 2021
Collaborator
There was a problem hiding this comment.
Good Work and thanks for your contribution! We only require 3 changes:
- To add the following line to the
doc/CHANGELOG.mdfile inside theunreleased section:
- Added
system/account. This returns the full information for a particular account with the specifiedaccount_id.
- To fix an error message as indicated in a thread above.
- Add a usage example in
demos/api_demo.py
DanielMagro97
requested changes
Sep 13, 2021
DanielMagro97
left a comment
DanielMagro97
left a comment
Collaborator
There was a problem hiding this comment.
Minor change in wording requested, but other than that and what Dylan has mentioned, looks good to me, thanks!
dillu24
requested changes
Oct 13, 2021
| print('/api/query/system/account') | ||
| r = requests.get(url=API_ENDPOINT + '/api/query/system/account', | ||
| params={'websocket': websocket, | ||
| 'account_address': 'HsGrsqL4nCBCW2ovc4kKG98c4mFp99BHRFkBSRZW1ETDe3U'}) |
Collaborator
There was a problem hiding this comment.
Shouldn't this be account_id?
Collaborator
|
@base1217 - Final change requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Getting account info is now available, especially free tokens amount. VERY VERY useful thing, at least for us:)
json responce output: