[MS-1377] Remove graph init state persistence that was never called#1606
Open
BurningAXE wants to merge 1 commit intomainfrom
Open
[MS-1377] Remove graph init state persistence that was never called#1606BurningAXE wants to merge 1 commit intomainfrom
BurningAXE wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Removes unused state persistence around the orchestrator navigation graph init flag, clarifying that graph initialization is intentionally not preserved across activity recreation (e.g., rotation / process recreation scenarios).
Changes:
- Removes
PersistableBundle-basedonSaveInstanceState()override and the unused persisted key forisGraphInitialized. - Stops restoring
isGraphInitializedfromsavedInstanceState, ensuring recreation re-initializes the graph. - Updates the inline documentation comment to reflect the intended lifecycle behavior.
You can also share your feedback on Copilot code review. Take the survey.
|
luhmirin-s
approved these changes
Mar 5, 2026
Contributor
luhmirin-s
left a comment
There was a problem hiding this comment.
Don't forget to test it :D
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



JIRA ticket
Will be released in: 2026.2.0
Root cause analysis (for bugfixes only)
First known affected version: an old one
Notable changes
onSaveInstanceState()which is only called whenpersistableMode="persistAcrossReboots"flag is setisGraphInitializedflag not persisting between activity recreationsonSaveInstanceState():DTesting guidance
Additional work checklist