Skip to content

[MS-1377] Remove graph init state persistence that was never called #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BurningAXE wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[MS-1377] Remove graph init state persistence that was never called #1606

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions ...ure/orchestrator/src/main/java/com/simprints/feature/orchestrator/OrchestratorActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ package com.simprints.feature.orchestrator

import android.content.Intent
import android.os.Bundle
import android.os.PersistableBundle
import androidx.core.os.bundleOf
import androidx.navigation.findNavController
import com.simprints.core.tools.activity.BaseActivity
Expand All @@ -29,15 +28,14 @@ internal class OrchestratorActivity : BaseActivity() {

/**
* Flag for the navigation graph initialization state. The graph should only be initialized once
* during the existence of this activity, and the flag tracks graph's state.
* while the activity is in memory. Recreation of the activity should result in graph re-init
*/
private var isGraphInitialized = false

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
Simber.d("OrchestratorActivity.onCreate isGraphInitialized=$isGraphInitialized", tag = ORCHESTRATION)

isGraphInitialized = savedInstanceState?.getBoolean(KEY_IS_GRAPH_INITIALIZED) ?: false
lifecycle.addObserver(activityTracker)

setContentView(binding.root)
Expand Down Expand Up @@ -80,16 +78,4 @@ internal class OrchestratorActivity : BaseActivity() {
finish()
}
}

override fun onSaveInstanceState(
outState: Bundle,
outPersistentState: PersistableBundle,
) {
outState.putBoolean(KEY_IS_GRAPH_INITIALIZED, isGraphInitialized)
super.onSaveInstanceState(outState, outPersistentState)
}

companion object {
private const val KEY_IS_GRAPH_INITIALIZED = "KEY_IS_GRAPH_INITIALIZED"
}
}
Loading