Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 2, 2026

CI failing on two issues: (1) dapp-fm packages embed demo-track.smsg (50MB, gitignored), (2) Go 1.25.0 emits stderr on packages without tests when using -coverprofile, causing non-zero exit.

Changes

Build tags for optional packages

  • Add // +build dappfm to cmd/dapp-fm* and pkg/player/assets.go
  • Create pkg/player/assets_stub.go (!dappfm tag) that excludes demo track, returns fs.ErrNotExist from GetDemoTrack()
  • Standard builds skip these packages; use -tags dappfm when demo file available

Taskfile test workaround

test:
  cmds:
    - |
      if output=$(go test -coverprofile=coverage.txt ./... 2>&1); then
        echo "$output"
      else
        # Only fail if actual test failures exist (not just covdata warnings)
        if echo "$output" | grep -q "^FAIL"; then
          echo "$output"
          exit 1
        else
          echo "$output"
        fi
      fi

Distinguishes real failures from Go 1.25.0's no such tool "covdata" warnings.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • invalid-url
    • Triggering command: /tmp/go-build3019234592/b493/website.test /tmp/go-build3019234592/b493/website.test -test.testlogfile=/tmp/go-build3019234592/b493/testlog.txt -test.paniconexit0 -test.timeout=10m0s conf�� 220236-3a3c6141ego1.25.0 220236-3a3c6141e-c=4 ux-amd64/pkg/tool/linux_amd64/vet (dns block)
    • Triggering command: /tmp/go-build376386275/b509/website.test /tmp/go-build376386275/b509/website.test -test.testlogfile=/tmp/go-build376386275/b509/testlog.txt -test.paniconexit0 -test.gocoverdir=/tmp/go-build376386275/b509/gocoverdir -test.timeout=10m0s -test.coverprofile=/tmp/go-build376386275/b509/_cover_.out s/web_identity_provider.go (dns block)
    • Triggering command: /tmp/go-build1019962875/b509/website.test /tmp/go-build1019962875/b509/website.test -test.testlogfile=/tmp/go-build1019962875/b509/testlog.txt -test.paniconexit0 -test.gocoverdir=/tmp/go-build1019962875/b509/gocoverdir -test.timeout=10m0s -test.coverprofile=/tmp/go-build1019962875/b509/_cover_.out ver .cfg p/go-build376386/home/REDACTED/go/pkg/mod/golang.org/toolchain@v0.0.1-go1.25.0.linux-amd64/pkg/toopercent encoding/csv -lang=go1.24 /home/REDACTED/go/-trimpath 3862�� /tmp/go-build376-p 386275/b495/covemain ux-amd64/pkg/tool/linux_amd64/cover 6016232/b458 main ted_at} ux-amd64/pkg/toopercent (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits February 2, 2026 06:48
Co-authored-by: Snider <631881+Snider@users.noreply.github.com>
Co-authored-by: Snider <631881+Snider@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix CI workflow to ensure reliable builds Fix CI: build tags for optional dapp-fm packages and Go 1.25 covdata workaround Feb 2, 2026
Copilot AI requested a review from Snider February 2, 2026 06:54
@Snider Snider marked this pull request as ready for review February 2, 2026 07:00
@gemini-code-assist
Copy link

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 2, 2026

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 2, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/player/assets_stub.go 0.00% 9 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants