fix: allowlist salvage_wreck and sell_ship in api-sync drift check#27
Open
statico-alt wants to merge 1 commit into
Open
fix: allowlist salvage_wreck and sell_ship in api-sync drift check#27statico-alt wants to merge 1 commit into
statico-alt wants to merge 1 commit into
Conversation
Both commands exist server-side (POST returns 401, not 404) but are absent from openapi.json, so the api-sync drift check failed on main. Add them to UNDOCUMENTED_IN_SPEC, matching the test's documented remedy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The api-sync drift check was failing on
main:salvage_wreckandsell_shipare present in the client'sCOMMANDSblock but missing from the liveopenapi.json, so the test flagged them as stale.Both commands still exist server-side — a
POSTto each returns401(auth required), not404— they're simply undocumented in the OpenAPI spec. Added them toUNDOCUMENTED_IN_SPEC, which is exactly the remedy the test documents for this case. No client behavior change.Player-Facing Release Notes