Skip to content

fix: allowlist salvage_wreck and sell_ship in api-sync drift check #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
statico-alt wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allowlist salvage_wreck and sell_ship in api-sync drift check #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/api-sync.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,10 @@
'v2_get_missions',
'v2_get_queue',
'v2_get_skills',

// Exist server-side (POST returns 401, not 404) but absent from openapi.json
'salvage_wreck',
'sell_ship',
]);

/**
Expand Down Expand Up @@ -96,7 +100,7 @@
expect(
missingCommands,
`API endpoints missing from client.ts:\n ${missingCommands.join('\n ')}\n\nAdd these to COMMANDS in client.ts.`,
).toEqual([]);

Check failure on line 103 in src/api-sync.test.ts

View workflow job for this annotation

GitHub Actions / test

error: API endpoints missing from client.ts 

:  cancel_ship_buy_order
  espionage
  faction_garages
  get_battle_log
  get_battle_summary
  get_notification_settings
  hunt
  inspect
  login_link
  login_link_poll
  mute_notifications
  place_ship_buy_order
  sell_ship_to_order
  shipping
  subscribe_observation
  unmute_notifications
  unsubscribe_observation
  view_ship_buy_orders

Add these to COMMANDS in client.ts.

- []
+ [
+   "api/catalog.json",
+   "cancel_ship_buy_order",
+   "espionage",
+   "faction_garages",
+   "get_battle_log",
+   "get_battle_summary",
+   "get_notification_settings",
+   "hunt",
+   "inspect",
+   "login_link",
+   "login_link_poll",
+   "mute_notifications",
+   "place_ship_buy_order",
+   "sell_ship_to_order",
+   "shipping",
+   "subscribe_observation",
+   "unmute_notifications",
+   "unsubscribe_observation",
+   "view_ship_buy_orders",
+ ]

- Expected  - 1
+ Received  + 21

      at <anonymous> (/home/runner/work/client/client/src/api-sync.test.ts:103:9)
},
15_000,
);
Expand Down
Loading